build system: add --no-warn-rwx-segments to linker#20381
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Mar 18, 2024
Merged
build system: add --no-warn-rwx-segments to linker#20381maribu merged 1 commit intoRIOT-OS:masterfrom
--no-warn-rwx-segments to linker#20381maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
Before we disabled the warning about RWX segments only for picolibc, but this issue is popping up on more and more toolchains (looking at MSP430 and RISC-V). Other than on `native`/`native64`, there is no MMU to enforce whatever permissions the segments contain anyway. (And writing to ROM with regular store instructions will not be possible even without the need for an MMU.) So let's just globally disable this warning, unless building for `native` and `native64`.
benpicco
added
the
CI: ready for build
Teufelchen1
approved these changes
Mar 12, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
Works as intended! Thanks, it really was annoying me.
Note: You are disregarding it lightly because "theres no MMU" but we do have systems with an MPU. Which could easily make the linker happy :> But that's an adventure the size of Narnia.
Member
Author
|
Thx :) |
maribu
changed the title
--no-warn-rwx-segments to linker--no-warn-rwx-segments to linker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Before we disabled the warning about RWX segments only for picolibc, but this issue is popping up on more and more toolchains (looking at MSP430 and RISC-V). Other than on
native/native64, there is no MMU to enforce whatever permissions the segments contain anyway. (And writing to ROM with regular store instructions will not be possible even without the need for an MMU.)So let's just globally disable this warning, unless building for
nativeandnative64.Testing procedure
Building in
masterwith RIOT-OS/riotdocker#248 will issue the RWX warning for every app now. And so does building on Alpine for MSP430.With this PR the in our context not helpful warning is disabled.
Issues/PRs references
Not necessary, but useful for RIOT-OS/riotdocker#248