cpu/msp430/f2xx: clean up periph_uart,periph_spi #20357
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Mar 28, 2024
Merged
cpu/msp430/f2xx: clean up periph_uart,periph_spi #20357maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
maribu
added
Type: cleanup
maribu
requested review from
MichelRottleuthner,
aabadie,
gschorcht,
kaspar030,
leandrolanzieri and
miri64
as code owners
github-actions
bot
added
Platform: MSP
benpicco
removed
the
State: waiting for other PR
maribu
force-pushed
the
cpu/msp430/usci
branch
from
494ae40 to
3b17adb
Compare
maribu
force-pushed
the
cpu/msp430/usci
branch
from
382cdee to
71ea5c8
Compare
benpicco
approved these changes
Mar 27, 2024
This cleans up the USCI based UART and SPI implementations and allows multiple instances of either interface to be configured by the boards. In addition, it allows sharing the USCI peripherals to provide multiple serial interfaces with the same hardware (round-robin).
Ran `dist/tools/insufficient_memory/update_insufficient_memory_board.sh` for both `z1` and `olimex-msp430-h2618`.
Member
Author
|
Wooohooo 🎉 Thx! |
This was referenced Apr 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This cleans up the USCI based UART and SPI implementations and allows
multiple instances of either interface to be configured by the
boards. In addition, it allows sharing the USCI peripherals to provide
multiple serial interfaces with the same hardware (round-robin).
Testing procedure
With an PCB sandwich consisting of an
olimex-msp430-h2618plugged into our Arduino UNO adapter and our peripheral selftest shield plugged into the other side of said adapter (so that SPI MISO and MOSI are conntected):Issues/PRs references
Depends on and includes: #20356