Murdock results

✔️ PASSED

fa7a577 tests/unittests: add test for ABS() macro

Artifacts

• Documentation preview

Looks like there is a name collision with a macro defined in a esp32 package. I am open to other names for the new macro. LIMIT_TO_RANGE() perhaps? Something shorter?

If you use the same definition as ESP32, would it still be a redefinition? 🤔

If you use the same definition as ESP32, would it still be a redefinition? 🤔

I tested the following and did not get an error or warning:

#define FOO 1
#define FOO 1

I don't know if that is promised by the language or just allowed by gcc. Do you know off the top of your head before I go looking? It does feel a bit precarious thought to rely on matching a macro defined outside the source tree.

I though about moving it to macros/math.h and calling it MATH_LIMIT(). That would require including utils.h in math.h. In my opinion MAX() and MIN()should be moved to math.h, but I think that change would affect a lot of people.

If it works on CI you can be sure that all supported compilers are covered.

Ok, I made the change.

Also I added the classic ABS macro to go with MAX/MIN.

Please squash!

squashed

Please wait to merge. I will added unit tests for these macros.

Ok, unit tests are added now for new and some existing macros.