Skip to content

tests/pkg/lwip: include default-radio-settings.inc.mk [backport 2024.01]#20330

Merged
benpicco merged 1 commit intoRIOT-OS:2024.01-branchfrom
miri64:backport/2024.01/tests/enh/lwip-radio-settings
Feb 2, 2024
Merged

tests/pkg/lwip: include default-radio-settings.inc.mk [backport 2024.01]#20330
benpicco merged 1 commit intoRIOT-OS:2024.01-branchfrom
miri64:backport/2024.01/tests/enh/lwip-radio-settings

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 2, 2024

Backport of #20325

Contribution description

For the release tests we decided to randomize the PAN ID to not interfere with ongoing RIOT-based experiments in the testbed (see RIOT-OS/Release-Specs#300). However, lwIP currently does not include the Makefile to set the PAN ID at compile time. This fixes that.

Testing procedure

Apply the following patch

diff --git a/drivers/netdev/ieee802154.c b/drivers/netdev/ieee802154.c
index cf5a39d4b4..9068a1e8fa 100644
--- a/drivers/netdev/ieee802154.c
+++ b/drivers/netdev/ieee802154.c
@@ -44,6 +44,7 @@ void netdev_ieee802154_reset(netdev_ieee802154_t *dev)
 
     /* Initialize PAN ID and call netdev::set to propagate it */
     dev->pan = CONFIG_IEEE802154_DEFAULT_PANID;
+    printf("PANID: 0x%04x\n", dev->pan);
     dev->netdev.driver->set(&dev->netdev, NETOPT_NID, &dev->pan, sizeof(dev->pan));
 
 #if IS_USED(MODULE_IEEE802154_SECURITY)

Then compile and flash tests/pkg/lwip to a board that has an IEEE 802.15.4 radio. Open a terminal and reboot. The node should now print PANID: 0x0023. If you then recompile and flash tests/pkg/lwip with DEFAULT_PAN_ID set to another value in the environment variables, e.g. DEFAULT_PAN_ID=0x1234, without this PR, the output will still be PANID: 0x0023, with this PR it will be PANID: 0x1234.

Issues/PRs references

Required for RIOT-OS/Release-Specs#300.

@miri64 miri64 added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Feb 2, 2024
@miri64 miri64 requested a review from MrKevinWeiss February 2, 2024 06:57
@riot-ci
Copy link
Copy Markdown

riot-ci commented Feb 2, 2024

Murdock results

✔️ PASSED

19fe1fb tests/pkg/lwip: include default-radio-settings.inc.mk

Success Failures Total Runtime
61 0 62 01m:11s

Artifacts

@benpicco benpicco enabled auto-merge February 2, 2024 08:05
@benpicco benpicco added this pull request to the merge queue Feb 2, 2024
Merged via the queue into RIOT-OS:2024.01-branch with commit 5d16f7e Feb 2, 2024
@miri64 miri64 deleted the backport/2024.01/tests/enh/lwip-radio-settings branch April 7, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants