pkg/wakaama: Notify resource updates when writing to resources#20326
Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom Feb 14, 2024
Merged
Conversation
leandrolanzieri
added
Area: network
leandrolanzieri
added
the
CI: ready for build
benpicco
approved these changes
Feb 12, 2024
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Pretty straightforward.
Have we ever tried getting those patches upstream?
We are using a version of the package that's 6 years old.
Contributor
Author
|
Thanks for reviewing :)
Not really, but I agree that's something towards which we should tend. I'll see if I can bump it and check what's still necessary. |
Contributor
Author
|
BTW #20930 finally bumps this package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently one can update LwM2M resources using the functionalities in
common.h. But this doesn't automatically marks them as changed for the LwM2M client to check if an observe notification may be required.This PR proposes to include marking the resource as changed upon write, thus giving the possibility to generate observation notifications.
I had to include a path to the package to mark the
uriPargument asconst. Additionally fixed the numbering of the patches files in the package (because apparently I can't count).Testing procedure
Issues/PRs references
You may want to take a look at #16204