Merged
Conversation
github-actions
bot
added
Area: build system
kaspar030
added
the
CI: ready for build
kaspar030
force-pushed
the
git-cache-rs
branch
from
3fd5a6a to
ecdf640
Compare
kaspar030
force-pushed
the
git-cache-rs
branch
from
43d1e70 to
f9afdf8
Compare
maribu
approved these changes
Jan 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
@MrKevinWeiss maybe backport this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds support for the Rust version of git-cache.
The shell version that we've integrated in
dist/tools/gitis quite a mess, barely maintainable. But most importantly, it is slow, and gets slower over time, due to the way the cache stores tags. Also, it doesn't support sparse checkouts. Crude measurements show that for our CI builds, for cortex-m builds 20-50% of time spent on each built are spent on checking out "pkg/cmsis".git-cache-rs' syntax is compatible with regular
git cloneto the point where anygit clone ...command that doesn't work with just changing togit cache cloneis considered a bug.Unfortunately that requires some changes. This PR introduces git-cache-rs support as fully optional, it'll only be used if
GIT_CACHE_RSis set to the binary name. The legacy built-in shell git-cache should continue working like before.git-cache-rs works a bit differently than the shell git-cache: instead of having one large bare cache repository that adds repos as remote, git-cache-rs just stores a "--mirror" repository for each cached repo. This is much simpler, although it might use a bit more space.
git-cache-rs supports sparse checkouts, which has been implemented here for
pkg/cmsis. I've updated dwq and the murdock container, and am currently testing those changes on ci-staging.riot-os.org.Testing procedure
I've been testing this PR together with the CI support in RIOT-OS/riotdocker#240 for a day or so on https://ci-staging.riot-os.org/.
Issues/PRs references