routing/rpl: Fixing styling & format#20294
Merged
chrysn merged 2 commits intoRIOT-OS:masterfrom Jan 24, 2024
Merged
Conversation
chrysn
approved these changes
Jan 24, 2024
Member
chrysn
left a comment
chrysn
left a comment
There was a problem hiding this comment.
Thanks. I don't spot any code changes, so this is a clean cleanup, and testing by the compiler will suffice to verify that static is justified.
(I'd like to have a way of making "this does not change the generated code" an assertion that is verified by the builders, but I don't know any tools to do that).
| (gnrc_rpl_internal_opt_dis_solicited_t*)options[i])) == NULL) { | ||
| return; | ||
| } | ||
| (gnrc_rpl_internal_opt_dis_solicited_t *)options |
Member
There was a problem hiding this comment.
I dislike the level of indent, but that would be for a discussion on the uncrustify settings, not this particular commit.
chrysn
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello! 🐚
This PR consists of two changes:
Because uncrustify would hide my changes regarding function signitures & variable renaming, I split it up in two commits.
I can understand if the second commit is objected - it's purely optional for me.
Testing procedure
Beside some
staticsno functional changes have been made. If it still builds and the ci passes, this should be fine!Issues/PRs references