Skip to content

boards/sodaq-sara-sff: add status pin for SARA#20279

Merged
dylad merged 1 commit intoRIOT-OS:masterfrom
keestux:add-sara-sff-status
Jun 1, 2024
Merged

boards/sodaq-sara-sff: add status pin for SARA#20279
dylad merged 1 commit intoRIOT-OS:masterfrom
keestux:add-sara-sff-status

Conversation

@keestux
Copy link
Copy Markdown
Contributor

@keestux keestux commented Jan 20, 2024

Contribution description

This adds a pin definition for SARA_STATUS on the sodaq-sara-sff board.

Testing procedure

Testing is only possible with this specific board, of course. Here is a code snippet to see it in operation.

    printf("SARA_STATUS: %d\n", gpio_read(SARA_STATUS_PIN));
    /* switch on the SARA Ublox */
    SARA_ENABLE_ON;
    SARA_TX_ENABLE_ON;
    /* Switch the PWR_ON pin to output */
    gpio_init(SARA_R4XX_PWR_ON_PIN, GPIO_OUT);
    SARA_R4XX_PWR_ON_OFF;
    xtimer_usleep(2000U * US_PER_MS);
    SARA_R4XX_PWR_ON_ON;
    /* Switch the PWR_ON pin back to input */
    gpio_init(SARA_R4XX_PWR_ON_PIN, GPIO_IN);
    printf("SARA_STATUS: %d\n", gpio_read(SARA_STATUS_PIN));

The output should then be:

SARA_STATUS: 0
SARA_STATUS: 1

@github-actions github-actions bot added the Area: boards Area: Board ports label Jan 20, 2024
@dylad
Copy link
Copy Markdown
Member

dylad commented Jan 23, 2024

This looks good to me.
@keestux there is only a small static test failure from doccheck that's need a fix.
Feel free to squash directly so we can merge this.

@dylad
Copy link
Copy Markdown
Member

dylad commented Feb 27, 2024

ping @keestux

@keestux keestux force-pushed the add-sara-sff-status branch from c38b855 to b079586 Compare March 26, 2024 21:02
dylad
dylad reviewed Mar 29, 2024
View reviewed changes
boards/sodaq-sara-sff/include/board.h Outdated
Comment on lines +149 to +155
/**
* @name SARA (UBlox) STATUS
*
* This is the V_INT of the SARA.
* @{
*/
#define SARA_STATUS_PIN GPIO_PIN(PA, 28)
Copy link
Copy Markdown
Member

@dylad dylad Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static test is failing again

Suggested change
/**
* @name SARA (UBlox) STATUS
*
* This is the V_INT of the SARA.
* @{
*/
#define SARA_STATUS_PIN GPIO_PIN(PA, 28)
#define SARA_STATUS_PIN GPIO_PIN(PA, 28) /**< This is the V_INT of the board */

I think this would make static-test happy

@keestux
Copy link
Copy Markdown
Contributor Author

keestux commented May 30, 2024

ping @keestux

Sorry about the delay. I've pushed a fixup as you suggested

@dylad
Copy link
Copy Markdown
Member

dylad commented May 31, 2024

@keestux I think we're all good now.
Please squash :)

@keestux keestux force-pushed the add-sara-sff-status branch from 0d2ac48 to 08862b2 Compare June 1, 2024 12:04
@keestux
Copy link
Copy Markdown
Contributor Author

keestux commented Jun 1, 2024

@keestux I think we're all good now. Please squash :)

Squashed

dylad
dylad approved these changes Jun 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2024
@dylad dylad enabled auto-merge June 1, 2024 20:45
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jun 1, 2024

Murdock results

✔️ PASSED

08862b2 boards/sodaq-sara-sff: add status pin for SARA

Success Failures Total Runtime
549 0 549 02m:20s

Artifacts

@dylad dylad added this pull request to the merge queue Jun 1, 2024
Merged via the queue into RIOT-OS:master with commit a67793d Jun 1, 2024
@keestux keestux deleted the add-sara-sff-status branch June 2, 2024 14:57
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylad dylad dylad approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keestux @dylad @riot-ci @mguetschow