nanocoap: implement coap_find_uri_query()#20273
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Jan 20, 2024
Merged
Conversation
github-actions
bot
added
Area: network
benpicco
changed the title
benpicco
added
the
Type: new feature
mguetschow
requested changes
Jan 18, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Good addition in general, smaller comments below.
mguetschow
requested changes
Jan 19, 2024
mguetschow
approved these changes
Jan 19, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Now that looks much cleaner and good to me now! :)
benpicco
force-pushed
the
coap_find_uri_query
branch
from
07e6579 to
4c7fc01
Compare
benpicco
added
the
CI: ready for build
Contributor
Author
|
Thank you for the review! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds a new function
coap_find_uri_query()with which we can find a URI query on a request packet.This makes handling requests with query options easier as we don't have to manually iterate all options in the handler.
Testing procedure
tests-nanocoapwas extended to exercise the new function.Issues/PRs references
suggested in #20197