tests: Slightly increase coverage of fmt unittests#20272
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Jan 23, 2024
Merged
tests: Slightly increase coverage of fmt unittests#20272mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: tests
MrKevinWeiss
approved these changes
Jan 18, 2024
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Heck ya, (many) small improvements are the best! Thanks, aside from small comments I would say ACK. You can squash directly.
Teufelchen1
force-pushed
the
chore/fmt_test_2
branch
from
59fc671 to
f07fa00
Compare
benpicco
added
the
CI: ready for build
mguetschow
reviewed
Jan 18, 2024
Teufelchen1
force-pushed
the
chore/fmt_test_2
branch
from
f07fa00 to
5feba2f
Compare
mguetschow
requested changes
Jan 19, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Looks way cleaner now indeed! Just one comment remaining.
Teufelchen1
force-pushed
the
chore/fmt_test_2
branch
from
5feba2f to
7c39b48
Compare
mguetschow
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello 🐑
Slightly increases the coverage of the unit tests. Despite shuffling the order of tests, no coverage is lost.
This also reorders the API definitions in
fmt.h- I'm sorry I just couldn't resist.Testing procedure
make -C tests/unittests/ tests-fmt testor just wait for the CIIssues/PRs references
Follow-up to #20198