Skip to content

Support added for board NUCLEO-C031C6, cpu STM32C031C6, and CPU_FAM_STM32C0#20267

Closed
jparker324 wants to merge 9 commits intoRIOT-OS:masterfrom
jparker324:stm32c0
Closed

Support added for board NUCLEO-C031C6, cpu STM32C031C6, and CPU_FAM_STM32C0#20267
jparker324 wants to merge 9 commits intoRIOT-OS:masterfrom
jparker324:stm32c0

Conversation

@jparker324
Copy link
Copy Markdown

Support added for ST Micro's board NUCLEO-C031C6, it's cpu STM32C031C6, and the rest of the cpu family STM32C0XX (as CPU_FAM_STM32C0). This currently includes STM32C011 and STM32C031, but code for identification has also been added for the STM32C071 and STM32C091 lines due out later this year.

Code was adapted from CPU_FAM_STM32G0 where applicable.

The most important difference in the STM32C0 product line is the removal of the PLL. As coded the default clock source is HSI.

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: doc Area: Documentation Area: build system Area: Build system Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Jan 16, 2024
@jparker324
Copy link
Copy Markdown
Author

Related issue #19210

@benpicco
Copy link
Copy Markdown
Contributor

Great addition, thank you!
One minor thing though: can you please split the commit into two, so you have one commit for the CPU changes and one for adding the board?
Also please prefix your commits with cpu/stm32: for the CPU and boards/nucleo-c031c6 for the board.

Other than that, this looks really good already 😃

Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some small things:

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Jan 25, 2024
@jparker324
Copy link
Copy Markdown
Author

See PR with corrected commit history #20300

@jparker324 jparker324 closed this Jan 25, 2024
@benpicco
Copy link
Copy Markdown
Contributor

You don't have to create a new PR, in the future when you edit your history with git rebase -i master you can just force push to your existing branch with git push -f

@jparker324 jparker324 deleted the stm32c0 branch January 31, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: tools Area: Supplementary tools Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants