core, sys, drivers: 64-bit support preparations#20257
Merged
maribu merged 3 commits intoRIOT-OS:masterfrom Jan 17, 2024
Merged
Conversation
Only minor changes are required to make the kernel 64 bit compatible. Most of the changes are either DEBUG/printf formatting or different types for void pointer casting. The only other change is the type of the `data` member in priority_queue_node_t, as `data` must be able to store a pointer. For current architectures, the assumption `sizeof(unsigned int) == sizeof(void *)` holds, but not for 64 bit. Therefore, the type is changed to `uintptr_t', which has the same size for the current architectures, but can also store a pointer in 64 bits.
benpicco
reviewed
Jan 15, 2024
kfessel
reviewed
Jan 17, 2024
maribu
reviewed
Jan 17, 2024
maribu
approved these changes
Jan 17, 2024
Member
|
Please squash! |
* priority_queue_t: Replaced `-1U` literal with PRIORITY_QUEUE_DATA_SIGNALING define * architecture.h: Added 64-bit * bloom.h: Fixed typedef for the hashfp_t function pointer * vfs.h: Increased default vfs buffer sizes for 64 bit * bytes.h: Check if socklen_t is already defined * ztimer: Use PRIxPTR format specifier
Fixed compilation errors for pointer casting.
6d234be to
3feb1a3
Compare
Contributor
Author
Done |
This was referenced Jan 18, 2024
This was referenced Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Since #20154 still seems a bit too big to discuss properly, I decided to split it into smaller PRs.
This PR includes the changes to
core,sysanddriversto enable 64-bit support.The commits are part of this patch series
Testing procedure
All tests and applications should remain unchanged for existing platforms.
Issues/PRs references
See also #19890, #20154