Skip to content

nanocoap_sock: implement FETCH methods#20238

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
benpicco:nanocoap_sock_fetch
Jan 10, 2024
Merged

nanocoap_sock: implement FETCH methods#20238
maribu merged 1 commit intoRIOT-OS:masterfrom
benpicco:nanocoap_sock_fetch

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Jan 9, 2024

Contribution description

Mostly for completeness' sake, works just like PUT/POST.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Jan 9, 2024
@benpicco benpicco requested review from bergzand and chrysn January 9, 2024 11:43
Copy link
Copy Markdown
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough, fits the pattern.

@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 9, 2024
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jan 9, 2024

Murdock results

✔️ PASSED

7240f70 nanocoap_sock: implement FETCH methods

Success Failures Total Runtime
8085 0 8085 16m:48s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@maribu
Copy link
Copy Markdown
Member

maribu commented Jan 10, 2024

The CI failure was a fluke

@maribu maribu added this pull request to the merge queue Jan 10, 2024
Merged via the queue into RIOT-OS:master with commit 5fa94b5 Jan 10, 2024
@benpicco benpicco deleted the nanocoap_sock_fetch branch January 10, 2024 12:19
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants