drivers/mtd: fix mtd_write_sector#20234
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jan 7, 2024
Merged
Conversation
Parameter `num` of `mtd_write_page_raw` is the number of bytes to be written, which is the number of sectors to be written`count` multiplied by the pages per sector `mtd->pages_per_sector` and the page size `mtd->page_size`.
gschorcht
added
Type: bug
benpicco
approved these changes
Jan 7, 2024
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Oops, good catch - thank you!
benpicco
added
the
Impact: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes
mtd_write_sectorfunction introduced with PR #20180.mtd_write_page_rawrequires the number of bytes to be written as parameter, which is the number of sectors to be written (parametercount) multiplied by the pages per sectormtd->pages_per_sectorand the page sizemtd->page_size.Testing procedure
Use any board with SPI SD Card interface and set
ENABLE_DEBUGindrivers/mtd_sdcard.c. Without the PR, writing to the SD card fails because of the wrong size. Formatting the SD card doesn't hangs.With the PR writing to the SD card and formatting it works as expected.
Issues/PRs references
Fixes PR #20180