Skip to content

sys/benchmark: fix integer overflow in benchmark_print_time()#20220

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
LP-HAW:fix-benchmark-overflow
Jan 4, 2024
Merged

sys/benchmark: fix integer overflow in benchmark_print_time()#20220
benpicco merged 1 commit intoRIOT-OS:masterfrom
LP-HAW:fix-benchmark-overflow

Conversation

@LP-HAW
Copy link
Copy Markdown
Contributor

@LP-HAW LP-HAW commented Jan 1, 2024

Contribution description

This PR fixes an integer overflow, that causes incorrect results to be reported when running a benchmark that takes longer than 4.2s.

Testing procedure

Run a benchmark that takes longer than 4.2s with less than 1us per function call.

Issues/PRs references

None

@github-actions github-actions bot added the Area: sys Area: System label Jan 1, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 2, 2024
@benpicco benpicco requested a review from haukepetersen January 2, 2024 12:10
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jan 2, 2024

Murdock results

✔️ PASSED

568cbc0 sys/benchmark: fix integer overflow in benchmark_print_time()

Success Failures Total Runtime
8100 0 8100 11m:09s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 3, 2024
Merged via the queue into RIOT-OS:master with commit 519f825 Jan 4, 2024
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants