Skip to content

makefiles/tests/tests.inc.mk: use native term for tests#20215

Merged
maribu merged 3 commits intoRIOT-OS:masterfrom
benpicco:tests/native-term
Jan 2, 2024
Merged

makefiles/tests/tests.inc.mk: use native term for tests#20215
maribu merged 3 commits intoRIOT-OS:masterfrom
benpicco:tests/native-term

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Dec 23, 2023 •
edited
Loading

Contribution description

Always use the native terminal for the automatic tests when using the native board.

Testing procedure

The affected tests should still succeed on native.

tests/sys/log_color on native 
% make test
r
/home/benpicco/dev/RIOT/tests/sys/log_color/bin/native/tests_log_color.elf tap0 
RIOT native interrupts/signals initialized.
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2024.01-devel-461-g5898c)
Logging value '42' and string 'test'
Logging value '42' and string 'test'
Logging value '42' and string 'test'
Logging value '42' and string 'test'
{ "threads": [{ "name": "idle", "stack_size": 8192, "stack_used": 436 }]}
{ "threads": [{ "name": "main", "stack_size": 12288, "stack_used": 2328 }]}

non-native tests should still work.

tests/sys/log_color on samr21-xpro 
% make BOARD=samr21-xpro flash test
Building application "tests_log_color" for "samr21-xpro" with MCU "samd21".

"make" -C /home/benpicco/dev/RIOT/pkg/cmsis/ 
"make" -C /home/benpicco/dev/RIOT/boards/common/init
"make" -C /home/benpicco/dev/RIOT/boards/samr21-xpro
"make" -C /home/benpicco/dev/RIOT/core
"make" -C /home/benpicco/dev/RIOT/core/lib
"make" -C /home/benpicco/dev/RIOT/cpu/samd21
"make" -C /home/benpicco/dev/RIOT/cpu/cortexm_common
"make" -C /home/benpicco/dev/RIOT/cpu/cortexm_common/periph
"make" -C /home/benpicco/dev/RIOT/cpu/sam0_common
"make" -C /home/benpicco/dev/RIOT/cpu/sam0_common/periph
"make" -C /home/benpicco/dev/RIOT/cpu/samd21/periph
"make" -C /home/benpicco/dev/RIOT/cpu/samd21/vectors
"make" -C /home/benpicco/dev/RIOT/drivers
"make" -C /home/benpicco/dev/RIOT/drivers/periph_common
"make" -C /home/benpicco/dev/RIOT/sys
"make" -C /home/benpicco/dev/RIOT/sys/auto_init
"make" -C /home/benpicco/dev/RIOT/sys/div
"make" -C /home/benpicco/dev/RIOT/sys/isrpipe
"make" -C /home/benpicco/dev/RIOT/sys/libc
"make" -C /home/benpicco/dev/RIOT/sys/log_color
"make" -C /home/benpicco/dev/RIOT/sys/malloc_thread_safe
"make" -C /home/benpicco/dev/RIOT/sys/newlib_syscalls_default
"make" -C /home/benpicco/dev/RIOT/sys/pm_layered
"make" -C /home/benpicco/dev/RIOT/sys/preprocessor
"make" -C /home/benpicco/dev/RIOT/sys/stdio_uart
"make" -C /home/benpicco/dev/RIOT/sys/test_utils/interactive_sync
"make" -C /home/benpicco/dev/RIOT/sys/test_utils/print_stack_usage
"make" -C /home/benpicco/dev/RIOT/sys/tsrb
   text	   data	    bss	    dec	    hex	filename
  13776	    132	   2356	  16264	   3f88	/home/benpicco/dev/RIOT/tests/sys/log_color/bin/samr21-xpro/tests_log_color.elf
/home/benpicco/dev/RIOT/dist/tools/edbg/edbg.sh flash /home/benpicco/dev/RIOT/tests/sys/log_color/bin/samr21-xpro/tests_log_color.bin
### Flashing Target ###
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800010523 01.1A.00FB (S)
Clock frequency: 16.0 MHz
Target: SAM R21G18 (Rev C)
Verification..... done.
Done flashing
r
/home/benpicco/dev/RIOT/dist/tools/pyterm/pyterm -p "/dev/ttyACM0" -b "115200" --no-reconnect --noprefix --no-repeat-command-on-empty-line 
Twisted not available, please install it if you want to use pyterm's JSON capabilities
Connect to serial port /dev/ttyACM0
Welcome to pyterm!
Type '/exit' to exit.
READY
s
START
main(): This is RIOT! (Version: 2024.01-devel-464-ga7cd27-tests/native-term)
Logging value '42' and string 'test'
Logging value '42' and string 'test'
Logging value '42' and string 'test'
Logging value '42' and string 'test'

Issues/PRs references

alternative to #20213

@benpicco benpicco requested a review from OlegHahm December 23, 2023 17:28
@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: tests Area: tests and testing framework Area: build system Area: Build system Area: boards Area: Board ports labels Dec 23, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 23, 2023
@benpicco benpicco mentioned this pull request Dec 23, 2023
Closed
@riot-ci
Copy link
Copy Markdown

riot-ci commented Dec 23, 2023 •
edited
Loading

Murdock results

✔️ PASSED

d8cc2ac tests: don't manually select native term

Success Failures Total Runtime
8098 0 8098 08m:57s

Artifacts

OlegHahm
OlegHahm reviewed Dec 23, 2023
View reviewed changes
@maribu maribu enabled auto-merge January 2, 2024 09:19
@maribu maribu added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2024
@maribu maribu added this pull request to the merge queue Jan 2, 2024
Merged via the queue into RIOT-OS:master with commit 0aa87aa Jan 2, 2024
@benpicco benpicco deleted the tests/native-term branch January 2, 2024 13:13
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 2, 2024

Copying from #20213 (comment):

I think the release tests need this as well: https://github.com/RIOT-OS/RIOT/actions/runs/7361658214/job/20039229745. :-/

Not sure, all tests there are covered by this (I hope so)

@miri64 miri64 mentioned this pull request Jan 8, 2024
Merged
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 8, 2024

Not sure, all tests there are covered by this (I hope so)

Sadly they are not :-(. See RIOT-OS/Release-Specs#296 for a workaround.

@benpicco benpicco mentioned this pull request Jan 16, 2024
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlegHahm OlegHahm OlegHahm left review comments

@maribu maribu maribu approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform

Projects

None yet

Milestone

Release 2024.01

Development

Successfully merging this pull request may close these issues.

6 participants

@benpicco @riot-ci @miri64 @OlegHahm @maribu @MrKevinWeiss