tests: use native terminal where necessary #20213
Closed
benpicco wants to merge 6 commits intoRIOT-OS:masterfrom
Closed
tests: use native terminal where necessary #20213benpicco wants to merge 6 commits intoRIOT-OS:masterfrom
native terminal where necessary #20213benpicco wants to merge 6 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
benpicco
added
Type: bug
benpicco
changed the title
native terminalnative terminal where necessary
OlegHahm
reviewed
Dec 22, 2023
Member
|
To me it would sound sane to run all native tests without pyterm: diff --git a/tests/Makefile.tests_common b/tests/Makefile.tests_common
index 5e988d903f..d96751c3ad 100644
--- a/tests/Makefile.tests_common
+++ b/tests/Makefile.tests_common
@@ -17,3 +17,7 @@ RIOTBASE ?= $(CURDIR)/../..
QUIET ?= 1
# DEVELHELP enabled by default for all tests, set 0 to disable
DEVELHELP ?= 1
+
+ifeq (native, $(BOARD))
+ RIOT_TERMINAL ?= native
+endif |
benpicco
force-pushed
the
pyterm_native-fixes
branch
from
a4842ae to
4d4afed
Compare
github-actions
bot
added
Platform: native
Contributor
Author
I agree, but we have many 'interactive' tests or tests that are more like examples where having How about only disabling |
Member
|
I think the release tests need this as well: https://github.com/RIOT-OS/RIOT/actions/runs/7361658214/job/20039229745. :-/ |
Contributor
Author
|
Closing this in favor of #20215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
For some reason those only are detected by CI when disabling Kconfig builds (#20211)
Testing procedure
Issues/PRs references
same as #20212