Skip to content

dist/tools/{ethos,zep_dispatch,dose,sliptty,usb-cdc-ecm}: allow setting host ip#20192

Open
mguetschow wants to merge 3 commits intoRIOT-OS:masterfrom
mguetschow:tap-host-ip
Open

dist/tools/{ethos,zep_dispatch,dose,sliptty,usb-cdc-ecm}: allow setting host ip#20192
mguetschow wants to merge 3 commits intoRIOT-OS:masterfrom
mguetschow:tap-host-ip

Conversation

@mguetschow
Copy link
Copy Markdown
Contributor

@mguetschow mguetschow commented Dec 19, 2023 •
edited
Loading

Contribution description

This adds an optional cmd option to start_network.sh for both ethos and zep_dispatch which allows to set the IP address automatically added on the host device (usually the development PC) when creating the tap interface. Additionally, the host address set now defaults to the same fd00:dead:beef::1.

examples/gnrc_border_router is adapted to showcase the usage.

Testing procedure

  1. make -C examples/gnrc_border_router all term and ip a l tap0 in a separate shell to see the (new) default host address fd00:dead:beef::1.
  2. same commands with IPV6_HOST_ADDR=2001:db8:1::1 to see the given host ip address is used. ping 2001:db8:1::1 in the RIOT shell to see it is reachable.
  3. same commands with an actual board (tested with BOARD=nrf52840dk) to test ethos.

Issues/PRs references

This has been discussed with @miri64 previously.

@github-actions github-actions bot added Area: tools Area: Supplementary tools Area: examples Area: Example Applications labels Dec 19, 2023
@mguetschow mguetschow marked this pull request as draft December 19, 2023 11:22
@mguetschow
Copy link
Copy Markdown
Contributor Author

mguetschow commented Dec 19, 2023

Revisiting the README of the gnrc_border_router example, it turns out a ULA address is already automatically added by the respective scripts, although not the same one. I will have a look again and probably change the PR to make those addresses consistent per default and configurable.

@github-actions github-actions bot added the Area: doc Area: Documentation label Dec 21, 2023
@mguetschow mguetschow marked this pull request as ready for review December 21, 2023 14:55
@mguetschow mguetschow requested a review from jia200x as a code owner December 21, 2023 14:55
@mguetschow
Copy link
Copy Markdown
Contributor Author

mguetschow commented Dec 21, 2023

I've changed the PR to allow setting the host IP address consistently for ethos and zep_dispatch. Now ready for review.

@benpicco benpicco requested a review from miri64 December 21, 2023 22:47
miri64
miri64 reviewed Jan 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But maybe the other integrations could benefit from this treatment as well:

  • dist/tools/dose/start_network.sh
  • dist/tools/sliptty/start_network.sh
  • dist/tools/usb-cdc-ecm/start_network.sh

@mguetschow
Copy link
Copy Markdown
Contributor Author

mguetschow commented Jan 19, 2024

But maybe the other integrations could benefit from this treatment as well:

Added similar changes to the other integrations now. Successfully tested sliptty with examples/gnrc_border_router, but couldn't find information on how to test the others. Maybe someone could give me a hint?

@mguetschow mguetschow changed the title dist/tools/{ethos,zep_dispatch}: allow setting host ip dist/tools/{ethos,zep_dispatch,dose,sliptty,usb-cdc-ecm}: allow setting host ip Jan 25, 2024
@mguetschow mguetschow requested a review from miri64 January 25, 2024 10:12
@mguetschow mguetschow mentioned this pull request Mar 19, 2024
Merged
@mguetschow
Copy link
Copy Markdown
Contributor Author

mguetschow commented May 16, 2024

Now this has been updated to support all five integrations, and I've successfully tested ethos, zep_dispatch, sliptty and usb-cdc-ecm with the gnrc_border_router example.

@mguetschow mguetschow requested review from benpicco and miri64 and removed request for miri64 May 16, 2024 11:42
mguetschow added 3 commits May 30, 2024 15:17
@mguetschow
dist/tools/{ethos,zep_dispatch}: allow setting host ip
dc5d526 
For both `ethos` and `zep_dispatch`, this adds an optional cmd option to `start_network.sh` which allows to automatically set an IP address for the host device (usually the development PC) when creating the tap interface.
@mguetschow
dist/tools/{dose,sliptty,usb-cdc-ecm}: pass host ip
ad84c9f
@mguetschow
examples/gnrc_border_router: allow passing host ip
2d5456e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@benpicco benpicco Awaiting requested review from benpicco

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Area: doc Area: Documentation Area: examples Area: Example Applications Area: tools Area: Supplementary tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mguetschow @miri64