Merged
Conversation
benpicco
added
the
CI: ready for build
benpicco
reviewed
Dec 6, 2023
OlegHahm
force-pushed
the
pr/pkg/flashdb/versionbump
branch
from
debc686 to
a06eaab
Compare
OlegHahm
added
the
CI: needs squashing
OlegHahm
force-pushed
the
pr/pkg/flashdb/versionbump
branch
from
a06eaab to
de609f8
Compare
OlegHahm
removed
the
CI: needs squashing
OlegHahm
force-pushed
the
pr/pkg/flashdb/versionbump
branch
from
9910d3a to
1c5e481
Compare
Contributor
|
You can directly squash trivial changes |
Member
Author
|
I prefer to keep changes visible until being reviewed as described in our Contributing guidelines. Since you have apparently now acknowledged the change I will squash. |
There are two more commits upstream after the 2.1.0 release which are required to compile this package without warnings.
OlegHahm
force-pushed
the
pr/pkg/flashdb/versionbump
branch
from
eb41a81 to
0e8b1c0
Compare
Contributor
|
The changes are still visible when you click the force-pushed link. (Ok, that assumes the rebase is done only on the current branch so e.g. |
Member
Author
|
Thanks for pointing to this feature. Maybe we should update the Contributing guide accordingly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Update to the latest version. Incorporate upstream patch by @fzi-haxel to prepare for 64bit platforms.
Testing procedure
The tests are still working:
pkg/flashdb_vfs
pkg/flashdb_mtd