drivers/mtd: fix the order of entries in the MTD pointer XFA mtd_dev_xfa#20113
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Nov 28, 2023
Merged
drivers/mtd: fix the order of entries in the MTD pointer XFA mtd_dev_xfa#20113benpicco merged 1 commit intoRIOT-OS:masterfrom
mtd_dev_xfa#20113benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
The commit fixes the order of entries in the MTD pointer XFA `mtd_dev_xfa` according to their index by using the index as the priority in the XFA.
benpicco
approved these changes
Nov 27, 2023
Contributor
Author
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The commit fixes the order of entries in the MTD pointer XFA
mtd_dev_xfaaccording to their index by using the index as the priority in the XFA.Since PR #19465, the pointers to existing MTD devices
mtd0,mtd1, ...mtd<n>are hold in the MTD pointer XFAmtd_dev_xfa. The order of these pointers in the XFA should correspond to their index so thatmtd_dev_xfa[i]givesmtd<i>which points to the i-th MTD. For that purpose theidxparameter of theMTD_XFA_ADDmacro has to be used as priority.Testing procedure
Compile
with and without this PR. Without this PR, command
will give
With this PR, the command should give:
Issues/PRs references