cpu/nrf5x: clean up periph_uart#20102
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Nov 26, 2023
Merged
Conversation
maribu
added
Type: cleanup
github-actions
bot
added
Platform: ARM
maribu
force-pushed
the
cpu/nrf5x_common/clean_up_uart
branch
2 times, most recently
from
fc9bd78 to
fa66a61
Compare
Member
|
I can test it on nRF53 too probably tonight or tomorrow if you want. |
Member
Author
That would be awesome! Thx 😄 |
dylad
approved these changes
Nov 26, 2023
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
nRF53 shell still works and changes looks good to me.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Seems like |
Member
Author
|
Indeed. But at least the I'll fix and squash when the kids are asleep :-) |
maribu
force-pushed
the
cpu/nrf5x_common/clean_up_uart
branch
from
fa66a61 to
a8eb54d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
maribu
force-pushed
the
cpu/nrf5x_common/clean_up_uart
branch
from
a8eb54d to
f2e1e4e
Compare
maribu
force-pushed
the
cpu/nrf5x_common/clean_up_uart
branch
from
f2e1e4e to
91c40ed
Compare
Member
Author
|
Now at least locally all boards build |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
- nRF51: Use `uart_conf_t` for consistency with nRF52 - nRF52832: Use UARTE (UART with EasyDMA) over UART (without DMA), as done for all other nRF52 family members - use `UARTE_PRESENT` to detect whether an UARTE can be used, rather than family names
Fixes the "comma should be followed by whitespace" warning from `static-tests`.
maribu
force-pushed
the
cpu/nrf5x_common/clean_up_uart
branch
from
91c40ed to
a28003f
Compare
maribu
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
Member
Author
|
And the usual forgot about KConfig issue 😅 |
Member
Author
|
🎉 thx :-) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
uart_conf_tfor consistency with nRF52UARTE_PRESENTto detect whether an UARTE can be used, rather than family namesTesting procedure
UART should still work on
nrf51-dk)nrf52840-dk)nrf52-dk)Issues/PRs references
None