Skip to content

sys/psa_crypto: Fix macro for public key max size and SE example [backport 2023.10]#20039

Merged
bors[bot] merged 2 commits intoRIOT-OS:2023.10-branchfrom
MrKevinWeiss:backport/2023.10/pr/psa-crypto-fix-se-example
Nov 2, 2023
Merged

sys/psa_crypto: Fix macro for public key max size and SE example [backport 2023.10]#20039
bors[bot] merged 2 commits intoRIOT-OS:2023.10-branchfrom
MrKevinWeiss:backport/2023.10/pr/psa-crypto-fix-se-example

Conversation

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss commented Nov 2, 2023

Backport of #19995

Contribution description

1. Wrong public key size when using secure elements, introduced by #19954

Fixed conditions for key size macros in crypto_sizes.h.

2. EdDSA and ECDSA examples fail when using a secure element because of unsopported changes introduced by #19954

Updated example/psa_crypto to use only supported functions for secure elements.

Testing procedure

Build example/psa_crypto for secure elements and run application

Output on master:

2023-10-19 14:33:24,372 # main(): This is RIOT! (Version: 2019.07-devel-22378-gb6772)
2023-10-19 14:33:24,372 # HMAC SHA256 took 56393 us
2023-10-19 14:33:24,372 # Cipher AES 128 took 68826 us
2023-10-19 14:33:24,372 # *** RIOT kernel panic:
2023-10-19 14:33:24,373 # HARD FAULT HANDLER
2023-10-19 14:33:24,373 # 
2023-10-19 14:33:24,373 # *** rebooting...

Output with fixes:

2023-10-19 13:35:24,715 # main(): This is RIOT! (Version: 2019.07-devel-22384-g8ef66-dev/psa-crypto-fixes)
2023-10-19 13:35:24,715 # HMAC SHA256 took 56374 us
2023-10-19 13:35:24,715 # Cipher AES 128 took 68805 us
2023-10-19 13:35:24,715 # ECDSA took 281164 us
2023-10-19 13:35:24,715 # All Done

@MrKevinWeiss MrKevinWeiss added Area: examples Area: Example Applications Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 2, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented Nov 2, 2023

Murdock results

✔️ PASSED

4f36d87 examples/psa_crypto: Update example to work with SEs

Success Failures Total Runtime
7937 0 7937 16m:34s

Artifacts

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Nov 2, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Nov 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2ffdc2c into RIOT-OS:2023.10-branch Nov 2, 2023
@MrKevinWeiss MrKevinWeiss deleted the backport/2023.10/pr/psa-crypto-fix-se-example branch November 6, 2023 11:52
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: examples Area: Example Applications Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2023.10

Development

Successfully merging this pull request may close these issues.

4 participants

@MrKevinWeiss @riot-ci @benpicco @Einhornhool