gcoap_fileserver: rename to nanocoap_fileserver#20030
Merged
benpicco merged 5 commits intoRIOT-OS:masterfrom Feb 1, 2024
Merged
gcoap_fileserver: rename to nanocoap_fileserver#20030benpicco merged 5 commits intoRIOT-OS:masterfrom
benpicco merged 5 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
cgundogan,
fjmolinas,
haukepetersen,
leandrolanzieri,
miri64 and
smlng
as code owners
github-actions
bot
added
Area: network
benpicco
added
the
Process: API change
chrysn
reviewed
Oct 30, 2023
benpicco
force-pushed
the
nanocoap_fileserver
branch
from
b3d70f9 to
3302492
Compare
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
nanocoap_fileserver
branch
from
3302492 to
ece2a13
Compare
kaspar030
added
CI: ready for build
Teufelchen1
added
CI: ready for build
Teufelchen1
approved these changes
Jan 30, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
LGTM, tested on native manually (on my machine). However the tests/net/gcoap_fileserver/ still fails. @MrKevinWeiss commented to me that this is a known issue, as seen in the makefile:
# This integration test uncovers a bug somwehere in our stack, but there
# are currently no resources to debug it, so blacklist it to keep CI running
TEST_ON_CI_BLACKLIST += all
Contributor
Author
Huh, that should only be a very sporadic failure that only triggers when CI is under high load (?). |
benpicco
force-pushed
the
nanocoap_fileserver
branch
from
ece2a13 to
c5ac574
Compare
Contributor
Author
|
I made a mistake when moving away from |
Contributor
|
Yes! Works as intended. I think you should squash it. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
There isn't really anything GCoAP specific about the fileserver module, it can just as well be used with nanoCoAP. Move and rename it to reflect that.
Testing procedure
Both
examples/gcoap_fileserverandexamples/nanocoap_serverkeep serving files, but the latter one without pulling in a GCoAP dependency.Issues/PRs references