drivers/include/periph: add FREQM peripheral driver#20020
Merged
benpicco merged 14 commits intoRIOT-OS:masterfrom Nov 27, 2023
Merged
drivers/include/periph: add FREQM peripheral driver#20020benpicco merged 14 commits intoRIOT-OS:masterfrom
benpicco merged 14 commits intoRIOT-OS:masterfrom
Conversation
gompper
requested review from
MichelRottleuthner,
MrKevinWeiss,
aabadie,
benpicco,
dylad,
fjmolinas,
jia200x,
keestux,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Platform: ARM
benpicco
reviewed
Oct 26, 2023
dylad
reviewed
Oct 26, 2023
benpicco
reviewed
Oct 26, 2023
dylad
reviewed
Nov 3, 2023
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
Give it a quick try and it works nice !
benpicco
reviewed
Nov 7, 2023
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
This is looking good!
Some nits and a suggestion to simplify the API:
cpu/samd5x/include/periph_cpu.h
Outdated
Comment on lines
+73
to
+75
| #ifndef SAM0_GCLK_MAIN | ||
| #define SAM0_GCLK_MAIN 0 /**< 120 MHz main clock */ | ||
| #endif |
Contributor
There was a problem hiding this comment.
Suggested change
| #ifndef SAM0_GCLK_MAIN | |
| #define SAM0_GCLK_MAIN 0 /**< 120 MHz main clock */ | |
| #endif | |
| #define SAM0_GCLK_MAIN 0 /**< 120 MHz main clock */ |
Main Clock is fixed to GCLK0
Contributor
Author
There was a problem hiding this comment.
Is it possible that SAM0_GCLK_32KHZ is also fixed? When trying to overwrite it I didn't get any text on the terminal.
Contributor
There was a problem hiding this comment.
It shoudln't be, unless it's hard-coded somewhere.
But maybe we should add some static_assert() to ensure no two GCLKs are configured to the same ID.
gompper
commented
Nov 13, 2023
benpicco
added
the
CI: ready for build
benpicco
reviewed
Nov 20, 2023
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks good!
Only some minor nitpicks.
benpicco
reviewed
Nov 20, 2023
benpicco
reviewed
Nov 23, 2023
benpicco
reviewed
Nov 23, 2023
benpicco
reviewed
Nov 23, 2023
benpicco
reviewed
Nov 23, 2023
gompper
force-pushed
the
periph/freqm
branch
from
b07dca4 to
bfb3b5f
Compare
benpicco
approved these changes
Nov 23, 2023
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks good, thank you for your contribution!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Looks like something is missing with Kconfig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a peripheral driver for frequency meter (FREQM). Tested with SAM E54 XPLAINED PRO EVALUATION KIT (ATSAME54P20A microcontroller).
I think I have access to some other boards to test the driver in the near future.
Testing procedure
As the FREQM needs a reference clock to measure the frequency of another clock this test uses two internal clocks. The slower internal clock is used as reference to measure the faster internal clock.
The test can be invoked with:
Expected result (via serial):