tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application by jan-mo · Pull Request #20005 · RIOT-OS/RIOT

jan-mo · 2023-10-20T15:05:15Z

This will extend the minmea test with additional NMEA sentences like GGA, GSA and RMC.

riot-ci · 2023-10-20T15:10:30Z

Murdock results

bdb1bc3 tests/pkg/minmea: exclude boards with small memory

Success	Failures	Total	Runtime
17	0	17	01m:11s

Artifacts

Documentation preview

benpicco · 2023-10-20T15:10:53Z

You also want to update tests/01-run.py otherwise the new outputs are not checked.

(You can test this by running make test)

tests/pkg/minmea/main.c

benpicco · 2023-10-23T09:04:36Z

bors merge

20005: tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application r=benpicco a=jan-mo This will extend the minmea test with additional NMEA sentences like GGA, GSA and RMC. Co-authored-by: Jan Mohr <[email protected]>

bors · 2023-10-23T09:05:50Z

Build failed:

Murdock

benpicco · 2023-10-23T09:08:09Z

Ah Makefile.ci needs an update because the test now no longer fits on tiny MCUs.

bors merge

20005: tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application r=benpicco a=jan-mo This will extend the minmea test with additional NMEA sentences like GGA, GSA and RMC. Co-authored-by: Jan Mohr <[email protected]>

bors · 2023-10-23T09:09:38Z

Build failed:

Murdock

jan-mo · 2023-10-23T09:21:23Z

bors merge

bors · 2023-10-23T09:21:25Z

🔒 Permission denied

Existing reviewers: click here to make jan-mo a reviewer

benpicco · 2023-10-23T09:22:05Z

bors merge

bors · 2023-10-23T09:22:09Z

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

20005: tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application r=benpicco a=jan-mo This will extend the minmea test with additional NMEA sentences like GGA, GSA and RMC. Co-authored-by: Jan Mohr <[email protected]>

bors · 2023-10-23T09:26:25Z

Build failed:

Murdock

jan-mo · 2023-10-23T14:16:48Z

bors

benpicco · 2023-10-23T14:20:04Z

bors merge

bors · 2023-10-23T14:43:46Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

kfessel · 2023-10-25T13:33:21Z

test work on native with TZ set to GMT-1

TZ=GMT-1 make test works

TZ=GMT make test fails

https://ci.riot-os.org/details/99a40c1ff07f43a6b985a7ac3a135cf0/builds/tests:pkg:minmea

vs

https://ci.riot-os.org/details/9023c32a91604a4689dea69acda5ac27

jan-mo · 2023-10-26T08:13:09Z

Yes I would strongly assume that it is dependent on the time zone you set on native. The RMC is given the time in UTC and in DDMMYY and hhmmss.ss.

See here https://docs.novatel.com/OEM7/Content/Logs/GPRMC.htm

jan-mo · 2023-10-26T08:24:24Z

We can also only check the date and time in the RMC message, so it will not be converted to an actual timestamp. I will create a follow up PR on that.

19932: tests/periph: Add test using the Peripheral Selftest Shield r=benpicco a=maribu ### Contribution description This adds a test that makes use of the peripheral selftesting shield. #### ToDo - [x] Add doc ### Testing procedure - grab an Arduino UNO compatible board that has the Arduino pin map feature - connect it to the testing shield - configure the testing shield - make sure the VCC selector matches the logic level of the board (3.3V and 5V are the only options) - enabled all the "loops" needed for testing on SW1 - it could be that the UART on D0, D1 is used for stdio. In that case, do *NOT* close the loop - flash and run the test application ### Issues/PRs references none 20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005) # how to test ``` TZ=GMT-1 make test ``` and ``` TZ=GMT make test ``` and ``` TZ=<any> make test ``` `timedatectl list-timezones` provides you with a List of timzones do not fail 20022: pkg/lwip: add support for slipdev r=benpicco a=benpicco 20025: tests/drivers/at: fix device table overflow r=benpicco a=krzysztof-cabaj ### Contribution description This PR fix device table overflow in `tests/driver/at`, which could lead to device crash. ### Testing procedure PR was tested on two nucleo boards with 2 and 3 UARTs (nucleo-l476rg and nucleo-l496zg). Flash `tests/driver/at` with and without this PR. Output with this PR: ``` > main(): This is RIOT! (Version: 2022.07-devel-5083-g2b9e8-tests-drivers-at) AT command test app > init 5 9600 Wrong UART device number - should by in range 0-2. > ``` Output without this PR: ``` > main(): This is RIOT! (Version: 2022.07-devel-5083-g2b9e8) AT command test app > init 5 9600 8001afd *** RIOT kernel panic: FAILED ASSERTION. *** halted. Context before hardfault: r0: 0x0000000a r1: 0x00000000 . . . ``` ### Issues/PRs references None Co-authored-by: Marian Buschsieweke <[email protected]> Co-authored-by: Jan Mohr <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]> Co-authored-by: krzysztof-cabaj <[email protected]>

19932: tests/periph: Add test using the Peripheral Selftest Shield r=benpicco a=maribu ### Contribution description This adds a test that makes use of the peripheral selftesting shield. #### ToDo - [x] Add doc ### Testing procedure - grab an Arduino UNO compatible board that has the Arduino pin map feature - connect it to the testing shield - configure the testing shield - make sure the VCC selector matches the logic level of the board (3.3V and 5V are the only options) - enabled all the "loops" needed for testing on SW1 - it could be that the UART on D0, D1 is used for stdio. In that case, do *NOT* close the loop - flash and run the test application ### Issues/PRs references none 20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005) # how to test ``` TZ=GMT-1 make test ``` and ``` TZ=GMT make test ``` and ``` TZ=<any> make test ``` `timedatectl list-timezones` provides you with a List of timzones do not fail Co-authored-by: Marian Buschsieweke <[email protected]> Co-authored-by: Jan Mohr <[email protected]>

20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005) # how to test ``` TZ=GMT-1 make test ``` and ``` TZ=GMT make test ``` and ``` TZ=<any> make test ``` `timedatectl list-timezones` provides you with a List of timzones do not fail Co-authored-by: Jan Mohr <[email protected]>

jan-mo requested review from MichelRottleuthner, aabadie, fjmolinas, leandrolanzieri and smlng as code owners October 20, 2023 15:05

github-actions bot added the Area: tests Area: tests and testing framework label Oct 20, 2023

jan-mo force-pushed the feat/20231020__adapting_nmea_message_test branch from 3a447aa to 425a47b Compare October 20, 2023 15:06

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 20, 2023

benpicco requested a review from kaspar030 October 20, 2023 15:09

benpicco reviewed Oct 20, 2023

View reviewed changes

tests/pkg/minmea/main.c Outdated Show resolved Hide resolved

jan-mo force-pushed the feat/20231020__adapting_nmea_message_test branch from 425a47b to 20cf475 Compare October 23, 2023 07:56

jan-mo added 2 commits October 23, 2023 10:32

tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application

1bfe45e

tests/pkg/minmea: adapting test file

d569cdf

jan-mo force-pushed the feat/20231020__adapting_nmea_message_test branch from 20cf475 to d569cdf Compare October 23, 2023 08:32

benpicco approved these changes Oct 23, 2023

View reviewed changes

benpicco added the CI: no fast fail don't abort PR build after first error label Oct 23, 2023

tests/pkg/minmea: exclude boards with small memory

bdb1bc3

jan-mo force-pushed the feat/20231020__adapting_nmea_message_test branch from 14464dc to bdb1bc3 Compare October 23, 2023 10:31

bors bot merged commit 238fb60 into RIOT-OS:master Oct 23, 2023

jan-mo mentioned this pull request Oct 26, 2023

tests/pkg/minmea: fixing RMC timestamp #20018

Merged

kfessel mentioned this pull request Oct 26, 2023

board/native: set TZ to UTC by default #20023

Merged

MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024

Conversation

jan-mo commented Oct 20, 2023

Uh oh!

riot-ci commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

benpicco commented Oct 20, 2023

Uh oh!

Uh oh!

benpicco commented Oct 23, 2023

Uh oh!

bors bot commented Oct 23, 2023

Uh oh!

benpicco commented Oct 23, 2023

Uh oh!

bors bot commented Oct 23, 2023

Uh oh!

jan-mo commented Oct 23, 2023

Uh oh!

bors bot commented Oct 23, 2023

Uh oh!

benpicco commented Oct 23, 2023

Uh oh!

bors bot commented Oct 23, 2023

Uh oh!

bors bot commented Oct 23, 2023

Uh oh!

jan-mo commented Oct 23, 2023

Uh oh!

benpicco commented Oct 23, 2023

Uh oh!

bors bot commented Oct 23, 2023

Uh oh!

kfessel commented Oct 25, 2023

Uh oh!

jan-mo commented Oct 26, 2023

Uh oh!

jan-mo commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

riot-ci commented Oct 20, 2023 •

edited

Loading