cmds_gnrc_netif: Support enabling/disabling lwIP netifs from gnrc_netif shell#19972
Merged
bors[bot] merged 5 commits intoRIOT-OS:masterfrom Oct 12, 2023
Merged
cmds_gnrc_netif: Support enabling/disabling lwIP netifs from gnrc_netif shell#19972bors[bot] merged 5 commits intoRIOT-OS:masterfrom
bors[bot] merged 5 commits intoRIOT-OS:masterfrom
Conversation
Similar to forcing interface up/down on Linux. In lwIP this is separate to link state.
yarrick
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
github-actions
bot
added
Area: network
miri64
added
State: waiting for other PR
miri64
approved these changes
Oct 12, 2023
Member
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
miri64
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Similar to Linux, lwIP has separate link and interface statuses.
This change expose this in a netopt and updates gnrc ifconfig to show and set it.
I am not really happy with the
NETOPT_ACTIVEname. MaybeNETOPT_STATEcould be renamed toNETOPT_RF_STATE?The code for setting up/down is not very nice. Not sure if link state will be controllable in lwIP - maybe for 6lowpan radios.
Testing procedure
Flash
tests/pkg/lwip. Any traffic received while the interface is down is dropped.Issues/PRs references
This only makes a difference when gnrc_netif ifconfig command is used. For that it depends on #19971 and an extra change like 7160ed9 to replace lwip netif with the gnrc version.