Skip to content

sys/shell/gnrc_netif: fix ifconfig set language issue#19970

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
krzysztof-cabaj:gnrc_netif_ifconfig
Oct 12, 2023
Merged

sys/shell/gnrc_netif: fix ifconfig set language issue#19970
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
krzysztof-cabaj:gnrc_netif_ifconfig

Conversation

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor

@krzysztof-cabaj krzysztof-cabaj commented Oct 11, 2023

Contribution description

This PR fix some language issues in the output of ifconfig set.

Testing procedure

Compile any program with gnrc_netif module, for example examples/gcoap.
Compare last line of presented outputs.

Output of ifconfig help without this PR.

All up, running the shell now
> ifconfig help
ifconfig help
usage: ifconfig help
usage: ifconfig <if_id> [up|down]
usage: ifconfig <if_id> set <key> <value>
      Sets an hardware specific specific value

Output of ifconfig help with this PR.

All up, running the shell now
> ifconfig help
ifconfig help
usage: ifconfig
usage: ifconfig help
usage: ifconfig <if_id> [up|down]
usage: ifconfig <if_id> set <key> <value>
      Sets a hardware specific value

Issues/PRs references

None

@github-actions github-actions bot added the Area: sys Area: System label Oct 11, 2023
@yarrick yarrick added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 11, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 11, 2023

Murdock results

✔️ PASSED

ce9c883 sys/shell/gnrc_netif: fix ifconfig set language issue

Success Failures Total Runtime
7937 0 7937 14m:56s

Artifacts

@yarrick
Copy link
Copy Markdown
Contributor

yarrick commented Oct 11, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 11, 2023

👎 Rejected by too few approved reviews

@yarrick
Copy link
Copy Markdown
Contributor

yarrick commented Oct 11, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 357e406 into RIOT-OS:master Oct 12, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yarrick yarrick yarrick approved these changes

Assignees

No one assigned

Labels

Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2023.10

Development

Successfully merging this pull request may close these issues.

4 participants

@krzysztof-cabaj @riot-ci @yarrick @MrKevinWeiss