sock/udp: work around gnrc_sock_recv() returning early timeout#19965
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Nov 28, 2023
Merged
sock/udp: work around gnrc_sock_recv() returning early timeout#19965benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
benpicco
added
the
Type: bug
benpicco
force-pushed
the
sock_udp_recv-ealry
branch
from
bcd07f5 to
6e60cfb
Compare
benpicco
force-pushed
the
sock_udp_recv-ealry
branch
from
6e60cfb to
1118a79
Compare
benpicco
added
the
CI: ready for build
Contributor
|
Should this be closed if #18977 is merged? |
benpicco
force-pushed
the
sock_udp_recv-ealry
branch
from
1118a79 to
bce6c23
Compare
benpicco
force-pushed
the
sock_udp_recv-ealry
branch
from
bce6c23 to
ae48e4e
Compare
maribu
approved these changes
Nov 13, 2023
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
Let's go with this for now and revert it when the underlying bug is fixed.
sock_udp_recv_buf_aux() sometimes will return -ETIMEDOUT before the given timeout has expired (e.g. 28798µs instead of 160000µs). This messes with many assumptions and breaks protocols that rely on the timeout. Until we have a proper fix, add this workaround.
benpicco
force-pushed
the
sock_udp_recv-ealry
branch
from
ae48e4e to
e3d0068
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
TODO: Revert this when #21113 is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
sock_udp_recv_buf_aux()sometimes will return-ETIMEDOUTbefore the given timeout has expired (e.g. after 28798µs instead of 160000µs).This messes with many assumptions and breaks protocols that rely on the timeout.
Until we have a proper fix, add this workaround.
Testing procedure
tests/net/gcoap_fileservershould now be more reliable even without the increased retries.Issues/PRs references