Skip to content

tests/unittests: blacklist LLVM on native#19958

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
benpicco:tests/unittests-blacklist_llvm
Oct 23, 2023
Merged

tests/unittests: blacklist LLVM on native#19958
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
benpicco:tests/unittests-blacklist_llvm

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Sep 29, 2023 •
edited
Loading

Contribution description

This test is randomly failing CI, so disable it.

Testing procedure

Hopefully less sporadic CI failures.

Issues/PRs references

same as #19634
708e5ea

@benpicco
tests/unittests: blacklist LLVM on native
7c718ae 
This test is randomly failing CI, so disable it.
@benpicco benpicco requested a review from miri64 as a code owner September 29, 2023 08:39
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Sep 29, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 29, 2023
@miri64
Copy link
Copy Markdown
Member

miri64 commented Sep 29, 2023

Isn't the reason why they are failing, because we deactivated them in CI and now lots of boards fell behind?

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Sep 29, 2023 •
edited
Loading

Yes, but we don't have any resources to fix native¹ currently, so we just disabled the offending tests.

[1] the problem that native is not FPU safe got worse as compilers and libc became more clever in recent years and will use 'FPU' registers (think SSE) for stuff like memcpy()

@benpicco benpicco requested a review from aabadie September 29, 2023 08:45
@maribu
Copy link
Copy Markdown
Member

maribu commented Oct 5, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 5, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 5, 2023
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 5, 2023

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 5, 2023

Murdock results

✔️ PASSED

7c718ae tests/unittests: blacklist LLVM on native

Success Failures Total Runtime
13 0 13 01m:31s

Artifacts

@maribu
Copy link
Copy Markdown
Member

maribu commented Oct 23, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit eee4ce1 into RIOT-OS:master Oct 23, 2023
@benpicco benpicco deleted the tests/unittests-blacklist_llvm branch October 23, 2023 09:01
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
@Tanyajackson638
Copy link
Copy Markdown

Tanyajackson638 commented Apr 29, 2024

7c718ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@aabadie aabadie Awaiting requested review from aabadie

Assignees

No one assigned

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2024.01

Development

Successfully merging this pull request may close these issues.

6 participants

@benpicco @miri64 @maribu @riot-ci @Tanyajackson638 @MrKevinWeiss