Skip to content

boards/esp32s3-wt32-sc01-plus: fix Kconfig#19953

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
gschorcht:boards/esp32s3-wt32-sc01-plus/fix_kconfig
Sep 28, 2023
Merged

boards/esp32s3-wt32-sc01-plus: fix Kconfig#19953
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
gschorcht:boards/esp32s3-wt32-sc01-plus/fix_kconfig

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Sep 28, 2023

Contribution description

This PR fixes a remaining Kconfig mismatch. It should fix the last compilation problem of the nightly.

Testing procedure

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/drivers/ili9341/ -b esp32s3-wt32-sc01-plus

should fail w/o this PR but should succeed with this PR.

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration labels Sep 28, 2023
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 28, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented Sep 28, 2023

Murdock results

✔️ PASSED

952bb26 boards/esp32s3-wt32-sc01-plus: fix Kconfig

Success Failures Total Runtime
521 0 521 03m:35s

Artifacts

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Sep 28, 2023

The testing procedure fails with this PR:

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/drivers/ili9341/ -b esp32s3-wt32-sc01-plus
tests/drivers/ili9341/         esp32s3-wt32-sc01-plus         FAIL: Kconfig hash mismatch

I tried on commit 952bb26

benpicco
benpicco previously approved these changes Sep 28, 2023
View reviewed changes
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Sep 28, 2023

The testing procedure fails with this PR:

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/drivers/ili9341/ -b esp32s3-wt32-sc01-plus
tests/drivers/ili9341/         esp32s3-wt32-sc01-plus         FAIL: Kconfig hash mismatch

What? 🤔

@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Sep 28, 2023

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/drivers/ili9341/ -b esp32s3-wt32-sc01-plus

I can't reproduce it. The output for me is:

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/drivers/ili9341/ -b esp32s3-wt32-sc01-plus
tests/drivers/ili9341/         esp32s3-wt32-sc01-plus         PASS
This took 0:01:10.243525...
You could have 2.16350057e-05 bitcoins mined

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Sep 28, 2023

Ok, my bad: I don't have the esp32 toolchain on my system. After adding -vv to the command line, I got this in the output: Compiler xtensa-esp32s3-elf-gcc is required but not found in PATH. Aborting.

I'm trying again with BUILD_IN_DOCKER=1 added. Not sure this might work or not.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Sep 28, 2023

So, I can't make it work using BUILD_IN_DOCKER=1. Let's just trust @gschorcht given output.

aabadie
aabadie approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Sep 28, 2023

bors merge

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @mrdeep1 @gschorcht
Merge #19946 #19953
5055152 
19946: posix_sockets.c: Fix 2 byte int compilation errors r=benpicco a=mrdeep1



19953: boards/esp32s3-wt32-sc01-plus: fix Kconfig r=aabadie a=gschorcht

### Contribution description

This PR fixes a remaining Kconfig mismatch. It should fix the last compilation problem of the nightly.

### Testing procedure

```
python3 dist/tools/compile_test/compile_like_murdock.py -a tests/drivers/ili9341/ -b esp32s3-wt32-sc01-plus
```
should fail w/o this PR but should succeed with this PR.

### Issues/PRs references


Co-authored-by: Jon Shallow <[email protected]>
Co-authored-by: Gunar Schorcht <[email protected]>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 28, 2023

Build failed (retrying...):

@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Sep 28, 2023

Build failed (retrying...):

Unrelated error.

@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Sep 28, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 28, 2023

Already running a review

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6a826fa into RIOT-OS:master Sep 28, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
@gschorcht gschorcht deleted the boards/esp32s3-wt32-sc01-plus/fix_kconfig branch December 6, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

@benpicco benpicco benpicco left review comments

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2023.10

Development

Successfully merging this pull request may close these issues.

5 participants

@gschorcht @riot-ci @aabadie @benpicco @MrKevinWeiss