boards/stm32f723e-disco: enable ST7789 display#19939
Merged
bors[bot] merged 3 commits intoRIOT-OS:masterfrom Sep 22, 2023
Merged
boards/stm32f723e-disco: enable ST7789 display#19939bors[bot] merged 3 commits intoRIOT-OS:masterfrom
bors[bot] merged 3 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
requested review from
MichelRottleuthner,
MrKevinWeiss,
aabadie,
fjmolinas,
jia200x,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Area: tests
gschorcht
added
Type: new feature
bors bot
added a commit
that referenced
this pull request
Sep 21, 2023
19937: drivers/lcd: add MCU 8080 16-bit parallel mode support r=benpicco a=gschorcht ### Contribution description This PR adds the 16-bit support for MCU 8080 parallel mode for LCD driver ICs. ### Testing procedure Use either PR #19938 ``` BOARD=stm32l496g-disco make -j8 -C tests/drivers/st77xx ``` or #19939 on top of this PR to test. ``` BOARD=sstm32f723e-disco make -j8 -C tests/drivers/st77xx ``` ### Issues/PRs references Prerequisite for PR #19938 or PR #19938 Co-authored-by: Gunar Schorcht <[email protected]>
benpicco
added
CI: ready for build
gschorcht
force-pushed
the
boards/stm32f723e-disco_enable_display
branch
from
8a190a8 to
47068b9
Compare
Contributor
Author
Contributor
|
This PR works and this is awesome! Good job! |
Contributor
Author
Thanks for testing. I will take a look into the Kconfig mismatch problem. |
aabadie
reviewed
Sep 22, 2023
aabadie
approved these changes
Sep 22, 2023
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Please squash! (there's another comment concerning a typo)
ACK
Contributor
|
Oh, this also needs a rebase :) |
gschorcht
force-pushed
the
boards/stm32f723e-disco_enable_display
branch
from
cd0c62a to
764ba06
Compare
fixup! boards/stm32f723e-disco: enable ST7789 display
gschorcht
force-pushed
the
boards/stm32f723e-disco_enable_display
branch
from
764ba06 to
1abcd73
Compare
Contributor
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Contributor
Author
|
Thanks. |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2023
19941: drivers/lcd: add MCU-driven low-level parallel interface r=benpicco a=gschorcht ### Contribution description The PR extends the LCD driver by a low-level interface for MCU-driven implementations of the MCU 8080 16-/8-bit parallel interface, allowing the MCU to use special peripherals for the interface, such as the FMC for STM32 MCUs, which is significantly faster than the integrated GPIO-driven parallel interface implementation of the LCD driver. ### Testing procedure ~Once PR #19938 and PR #19939 are merged, a PRs for these board can be pushed that allow to test this PR.~ Use either PR #19943 or PR #19944 on top of this PR to test, e.g. with PR #19943: ``` BOARD=stm32f723e-disco make -j8 -C tests/drivers/st77xx flash ``` ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR enables the ST7789 display and the touch panel for the
stm32f723e-disco.The PR requires PR #19937.
Testing procedure
should work.
Issues/PRs references
Depends on PR #19937