gnrc_ipv6_nib: fix for border router with non-6lo interfaces#19900
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Aug 24, 2023
Merged
Conversation
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
benpicco
added
Type: bug
benpicco
force-pushed
the
gnrc_sixlowpan_border_router-heterogenous
branch
from
e1ddce9 to
43aeee8
Compare
fabian18
reviewed
Aug 24, 2023
Contributor
fabian18
left a comment
fabian18
left a comment
There was a problem hiding this comment.
The changes make sense to me. But I do not fully understand your description. Did you observe a non-6LN interface send RAs for every stored border router?
A border router should not send router advertisements on it's 6LoWPAN interfaces, but if it also has classic IPv6 downstream interfaces it should very much do so.
benpicco
force-pushed
the
gnrc_sixlowpan_border_router-heterogenous
branch
from
43aeee8 to
d383796
Compare
Contributor
Author
No, I did observe the non-6LN interface not send any RAs because the |
Contributor
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 24, 2023
19900: gnrc_ipv6_nib: fix for border router with non-6lo interfaces r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
Author
|
bors cancel bors merge |
Contributor
|
Canceled. |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
A border router should not send router advertisements on it's 6LoWPAN interfaces, but if it also has classic IPv6 downstream interfaces it should very much do so.
Testing procedure
Issues/PRs references