drivers/stmpe811: introduce conversion for X and Y coordinates#19883
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Sep 2, 2023
Merged
drivers/stmpe811: introduce conversion for X and Y coordinates#19883bors[bot] merged 1 commit intoRIOT-OS:masterfrom
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
Conversation
gschorcht
added
Type: bug
gschorcht
force-pushed
the
drivers/stmpe811_rotation_option
branch
from
e239116 to
353b815
Compare
gschorcht
added
the
State: WIP
gschorcht
force-pushed
the
drivers/stmpe811_rotation_option
branch
from
353b815 to
3d2229b
Compare
gschorcht
removed
the
State: WIP
gschorcht
force-pushed
the
drivers/stmpe811_rotation_option
branch
from
3d2229b to
98c8ee7
Compare
gschorcht
changed the title
Contributor
|
Looks good but needs a rebase |
To obtain coordinates from the touch panel that correspond to the display coordinates, it is often necessary to convert the coordinates from the touch display by swapping and mirroring. For the sake of simplicity, possible rotations are additionally defined.
gschorcht
force-pushed
the
drivers/stmpe811_rotation_option
branch
from
98c8ee7 to
ebe51e7
Compare
Contributor
Author
Done. |
aabadie
approved these changes
Sep 2, 2023
Contributor
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Contributor
Author
|
@aabadie Many thanks for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
To obtain coordinates from the touch panel that correspond to the display coordinates, it is often necessary to convert the coordinates by swapping and mirroring. Instead of hard coding this conversion, it is now controlled by an additional conversion parameter. For the sake of simplicity, possible rotations are predefined.
The PR fixes
tests/pkg/lgvl_touchfor thestm32f429i-disc1board where the coordinates from the touch panel seem to be mirrored in relation to the screen coordinates at the vertical axis.Testing procedure
Flash
tests/pkg/lvgl_touch. Without this PR the coordinates of the button don't correspond to the touch panel coordinates once the button has been pressed. Instead they seem to be mirrored at the vertical axis. With this PR, the coordinates should be correct.Issues/PRs references