coap: add missing option numbers#19874
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Aug 21, 2023
Merged
Conversation
leandrolanzieri
added
the
Type: new feature
leandrolanzieri
approved these changes
Aug 11, 2023
leandrolanzieri
added
Reviewed: 1-fundamentals
Contributor
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 11, 2023
19874: coap: add missing option numbers r=leandrolanzieri a=JKRhb Co-authored-by: Jan Romann <[email protected]>
Member
|
bors merge |
Contributor
|
Already running a review |
Contributor
|
Build failed: |
Member
Author
|
Hmm, if I see it correctly, the build error occurring in Murdock is also present on the main branch: https://ci.riot-os.org/details/012e0ce20f46455da0d9a595e2439a72 How should we proceed here? |
Member
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 11, 2023
19874: coap: add missing option numbers r=maribu a=JKRhb Co-authored-by: Jan Romann <[email protected]>
Contributor
|
Build failed: |
Contributor
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 21, 2023
19387: drivers/atwinc15x0: support dynamic scanning and connection to AP r=benpicco a=fabian18 19874: coap: add missing option numbers r=benpicco a=JKRhb 19875: coap: add missing Content-Format definitions r=benpicco a=JKRhb 19876: sys/net/ipv4/addr: fix typos r=benpicco a=Enoch247 ### Contribution description This patch fixes some typos in the doxygen doc. ### Testing procedure Nothing to test. No change to code. ### Issues/PRs references - None known 19878: makefiles/usb_board_reset.mk: declare term-delay target with test target r=benpicco a=aabadie 19886: cpu/efm32: fix DAC configuration r=benpicco a=gschorcht ### Contribution description The EFM32 MCU allows the reference voltage to be configured per DAC device, not per DAC channel. Also, the DAC reference voltage was defined in the configuration but not used anywhere. At the moment we have only defined one board (`stwstk6220a`) that uses the DAC, so changing the configuration interface shouldn't be critical. ### Testing procedure `tests/periph/dac` should still work for the `stwstk6220a` ``` BOARD=slwstk6220a make -j8 -C tests/periph/dac flash ``` I don't have a `stwstk6220a` board (EFM32 Series 0) so that I can't test it. I could only test it for the `sltb009a` board (EFM32 Series 1) with the change for VDAC in PR #19887. ### Issues/PRs references 19888: boards/sltb009a: complete and fix documentation r=benpicco a=gschorcht ### Contribution description This PR completes and fixes the documentation which was still in the state as generated automatically by `efm2riot`. The PR also includes a fix of the configuration of the second UART device that was find out while completing the documentation. ### Testing procedure Green CI ### Issues/PRs references Co-authored-by: Fabian Hüßler <[email protected]@MLPA-NB119.(none)> Co-authored-by: Fabian Hüßler <[email protected]> Co-authored-by: Jan Romann <[email protected]> Co-authored-by: Joshua DeWeese <[email protected]> Co-authored-by: Alexandre Abadie <[email protected]> Co-authored-by: Gunar Schorcht <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
In
coap.h, there are currently a few option numbers from the IANA registry missing. This PR closes the gaps.Although no implementation is provided for the features associated with the options yet, it might still be useful to have the options defined already, e.g. for application developers.
Testing procedure
Since there is no new logic introduced, comparing the numbers with the IANA registry and proofreading the documentation should suffice for this PR.
Issues/PRs references
–