make: COMPILE_COMMANDS_PATH adapt for external apps#19869
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Aug 9, 2023
Merged
make: COMPILE_COMMANDS_PATH adapt for external apps#19869bors[bot] merged 1 commit intoRIOT-OS:masterfrom
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
the
CI: ready for build
maribu
approved these changes
Aug 9, 2023
Contributor
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
COMPILE_COMMANDS_PATHcurrently defaults toRIOTBASEwhich may not be an parent path for external applications -> set toAPPDIRin caseTesting procedure
current good will stay good
test with riot examples and or testes
$make compile-commandsshould create acompile_command.jsonin<RIOT>test with external app Makefile including
include $(RIOTBASE)/Makefile.includeshould create
compile_command.jsoninAPPDIRIssues/PRs references