drivers/ft5x06: introduce conversion for X and Y coordinates#19867
Merged
bors[bot] merged 3 commits intoRIOT-OS:masterfrom Aug 27, 2023
Merged
drivers/ft5x06: introduce conversion for X and Y coordinates#19867bors[bot] merged 3 commits intoRIOT-OS:masterfrom
bors[bot] merged 3 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: drivers
gschorcht
added
Type: new feature
gschorcht
added
the
State: WIP
gschorcht
force-pushed
the
drivers/ft5x06_xy_conversion
branch
from
c66e7ed to
2844f5a
Compare
gschorcht
removed
the
State: WIP
gschorcht
force-pushed
the
drivers/ft5x06_xy_conversion
branch
from
2844f5a to
622d959
Compare
aabadie
removed
the
State: waiting for other PR
Contributor
|
👎 Rejected by PR status |
Contributor
|
bors merge |
Contributor
|
👎 Rejected by PR status |
benpicco
added
CI: ready for build
Contributor
|
bors merge |
Contributor
|
👎 Rejected by PR status |
Contributor
Author
|
Why the hell doesn't bors like this PR? If I'm right, we had the same problem with |
To obtain coordinates from the touch panel that correspond to the display coordinates, it is often necessary to convert the coordinates from the touch display by swapping and mirroring. For the sake of simplicity, possible rotations are additionally defined.
gschorcht
force-pushed
the
drivers/ft5x06_xy_conversion
branch
from
622d959 to
26ed7e6
Compare
aabadie
added
CI: ready for build
Contributor
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Contributor
Author
|
@aabadie Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides the parameter option to define how the X and Y coordinates have to be converted.
To get coordinates from the touch panel that correspond to the display coordinates, it is often necessary to convert the coordinates from the touch pannel by swapping and mirroring them. For the sake of simplicity, possible rotations are additionally defined.
The PR includes PRs #19860 and #19866 to be compilable.
Testing procedure
tests/pkg/lvgl_touchshould still work for thestm32f746g-discoboard.Issues/PRs references
Depends on PR #19860Depends on PR #19866