Skip to content

tests/pkg/lvgl*: fix the main thread stack size for ESPs#19865

Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
gschorcht:tests/pkg/lvgl_fix_main_stack_size
Aug 9, 2023
Merged

tests/pkg/lvgl*: fix the main thread stack size for ESPs#19865
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
gschorcht:tests/pkg/lvgl_fix_main_stack_size

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Aug 9, 2023

Contribution description

ESPx SoC need more stack size for the main thread to avoid stack overflows.

Testing procedure

Use any ESP32 board or any ESP32-S2 board and flash tests/pkg/lvgl for the esp32-wrover-kit respective the esp32s2-lilygo-ttgo-t8, for example:

BOARD=esp32-wrover-kit make -j8 -C tests/pkg/lvgl flash

Without this PR the application crashes

main(): This is RIOT! (Version: 2023.10-devel-106-gd512f-tests/pkg/lvgl_fix_main_stack_size)
EXCEPTION!! exccause=29 (StoreProhibitedCause) @4008274a excvaddr=fefffffb
heap: 310368 (used 4176, free 306192) [bytes]

register set
pc      : 40082f74	ps      : 00050033	exccause: 0000001d	excvaddr: fefffffb
epc1    : 40082f74	
a0      : 4008274a	a1      : 3ffb1bd0	a2      : fefffff7	a3      : 00000000
a4      : 3ff000dc	a5      : 400826e0	a6      : 00000000	a7      : 3ffb1e08
a8      : 0000000b	a9      : 3ffb1df8	a10     : 3ffb1e7c	a11     : 00000001
a12     : 00000000	a13     : 00000000	a14     : 00000000	a15     : 000000a3

with this PR the application works as expected.

Issues/PRs references

@gschorcht
tests/pkg/lvgl: increase main thread stack size for ESPs
2a87213 
ESPx SoC need more stack size for the main thread to avoid stack overflows.
@gschorcht
tests/pkg/lvgl_touch: increase main thread stack size for ESPs
db71529 
ESPx SoC need more stack size for the main thread to avoid stack overflows.
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Aug 9, 2023
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 9, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented Aug 9, 2023

Murdock results

✔️ PASSED

db71529 tests/pkg/lvgl_touch: increase main thread stack size for ESPs

Success Failures Total Runtime
29 0 29 01m:24s

Artifacts

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Aug 9, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Aug 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 91441db into RIOT-OS:master Aug 9, 2023
@gschorcht gschorcht deleted the tests/pkg/lvgl_fix_main_stack_size branch September 3, 2023 14:15
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

No one assigned

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2023.10

Development

Successfully merging this pull request may close these issues.

4 participants

@gschorcht @riot-ci @benpicco @MrKevinWeiss