Skip to content

cpu/riscv_common: remove picolibc from blacklisting in CI#19862

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/riscv_common/remove_blacklist_picolib_ci
Aug 7, 2023
Merged

cpu/riscv_common: remove picolibc from blacklisting in CI#19862
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/riscv_common/remove_blacklist_picolib_ci

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Aug 7, 2023 •
edited
Loading

Contribution description

picolibc is now supported by the RISC-V toolchain in riotdocker. It is not necessary to blacklist it in CI any longer.

Reference: picolib was blacklisted by commit 45270da in PR #15011.

Testing procedure

  1. Green CI
  2. Check feature list for CI compilation: 
    BUILD_IN_DOCKER=1 RIOT_CI_BUILD=1 FEATURES_OPTIONAL=picolibc \
BOARD=sipeed-longan-nano make -j8 -C tests/sys/shell info-modules | grep picolib
picolibc
picolibc_stdout_buffered
picolibc_syscalls_default

Issues/PRs references

@github-actions github-actions bot added Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Aug 7, 2023
@gschorcht gschorcht requested a review from benpicco August 7, 2023 11:29
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Aug 7, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented Aug 7, 2023

Murdock results

✔️ PASSED

e1ea18f cpu/riscv_common: remove picolibc from blacklisting in CI

Success Failures Total Runtime
7907 0 7907 13m:36s

Artifacts

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Aug 7, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Aug 7, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d512ff6 into RIOT-OS:master Aug 7, 2023
@gschorcht gschorcht deleted the cpu/riscv_common/remove_blacklist_picolib_ci branch August 8, 2023 05:33
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Aug 8, 2023

@benpicco Thanks for reviewing and merging.

@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2023.10

Development

Successfully merging this pull request may close these issues.

4 participants

@gschorcht @riot-ci @benpicco @MrKevinWeiss