drivers/ft5x06: fix vendor ID for FT6xx6 and FTxxxx register addresses by gschorcht · Pull Request #19860 · RIOT-OS/RIOT

gschorcht · 2023-08-06T15:49:42Z

Contribution description

This PR provides a fix of the vendor ID for FT6xx6 touch panel driver ICs and a fix of register addresses for FTxxxx.

According to the Application Note for FT6x06 CTPM, the vendor ID of FT6x06 touch panel driver ICs is 0x11 instead of 0xcd. Although there are no information found in the Web about the FT6x36, the FT6336U touch panel of a ESP32-S3 WT32 SC01 Plus is also working with 0x11 as vendor ID so that it seems that FT6x36 is also using 0x11 as vendor ID.

Figured out with a stm32f723e-disco board (revision D03). Without this PR, tests/drivers/ft5x06 gives:

+------------Initializing------------+
[ft5x06] init: invalid vendor ID: '0x11' (expected: 0xcd)
[Error] Initialization failed

With this PR it works as expected.

+------------Initializing------------+
Initialization successful
main(): This is RIOT! (Version: 2023.10-devel-96-gbb9011-drivers/ft5x06_fix_vendor_id)
FT5x06 test application

+------------Initializing------------+
[ft5x06] init: configuring touchscreen interrupt
Initialization successful
1 touch detected
[ft5x06] read gesture_id '0x00'
Touch 1 - X: 151, Y:138
[ft5x06] read gesture_id '0x00'

Some background information found in the Web:

According to the STM32CubeF7 the FRIDA LCD panel mounted on the stm32f723e-disco board either uses FT6x36 (prior revision D) or FT3x67 (revision D). However, the FT5x06 driver type for the card is defined as FT6x06, which does not seem correct:

RIOT/boards/stm32f723e-disco/include/board.h

Line 59 in bb9011c

#define FT5X06_PARAM_TYPE FT5X06_TYPE_FT6X06 /**< Device type */
According to the STM32CubeF7, the vendor ID for FT6x36 should be 0xcd. However, the FT6336U on ESP32-S3 WT32 SC01 Plus works with vendor ID 0x11.
The Adafruit FT6206 library uses 0x11 as vendor id.
The stm32l496g-disco board uses a FT6236 which has vendor ID 0xcd.

So the information available on the web is confusing. Maybe, a better solution would be to accept 0x11 as well as 0xcd as vendor ID for FT6xxx touch panels. Unfortunately, there are no documents available on the registers directly from FocalTech 😟 so it seems to be more speculation than knowledge.

Testing procedure

Issues/PRs references

The vendor ID of FT6xx6 touch panel driver ICs is `0x11` instead of `0xcd`.

riot-ci · 2023-08-06T15:59:27Z

Murdock results

✔️ PASSED

a9f3ce1 drivers/ft5x06: fix register addresses

Success	Failures	Total	Runtime
7938	0	7939	13m:38s

Artifacts

Documentation preview

benpicco

I'm trusting your testing on this one.

gschorcht · 2023-08-07T10:42:27Z

I'm trusting your testing on this one.

Unfortunately, it is more complicated than it looked. There are indeed STM32 boards with FT6236 which uses 0xcd instead of 0x11 as vendor ID (I had to learn that my stm32l496-disco board is one of them) although all other driver libraries for FT6x36 use 0x11 such as the Adafruit library that is used for their LCD display with FT6236U.

I'm working on a solution that will work with both vendor IDs.

gschorcht · 2023-08-09T08:18:42Z

@benpicco Now it checks for both 0x11 as well as 0xcd as vendor ID for FT6xxx` models.

Furthermore, when trying to use gesture which don't work at all for FTxxxx, I found a bug in register addresses that is also fixed now with this PR.

gschorcht · 2023-08-14T13:51:44Z

@benpicco Does the ACK still apply?

benpicco · 2023-08-14T21:44:24Z

Sure!

gschorcht · 2023-08-14T22:07:03Z

Sure!

I sqashed it.

benpicco · 2023-08-23T09:49:51Z

bors merge

bors · 2023-08-23T09:49:56Z

👎 Rejected by PR status

benpicco · 2023-08-23T16:54:50Z

bors merge

bors · 2023-08-23T20:30:28Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

gschorcht · 2023-08-23T21:34:08Z

Thanks

19866: drivers/ft5x06: use a pointer to config parameters instead of copying them r=benpicco a=gschorcht ### Contribution description There is no need to copy the configuration parameter set to the device descriptor. A const pointer to the configuration parameter set in ROM is sufficient. It saves 16 byte of RAM. Includes PR #19860 for the moment to be compilable. ### Testing procedure Use ``` CFLAGS='-DNDEBUG' BOARD=stm32f723e-disco make -j8 -C tests/drivers/touch_dev/ ``` with and w/o this PR and compare the sizes. Without the PR the sizes are: ``` text data bss dec 14652 136 2704 17492 ``` With the PR the sizes are: ``` text data bss dec 14676 136 2688 17500 ``` ### Issues/PRs references ~Depends on PR #19860~ Co-authored-by: Gunar Schorcht <[email protected]>

19867: drivers/ft5x06: introduce conversion for X and Y coordinates r=aabadie a=gschorcht ### Contribution description This PR provides the parameter option to define how the X and Y coordinates have to be converted. To get coordinates from the touch panel that correspond to the display coordinates, it is often necessary to convert the coordinates from the touch pannel by swapping and mirroring them. For the sake of simplicity, possible rotations are additionally defined. The PR includes PRs #19860 and #19866 to be compilable. ### Testing procedure `tests/pkg/lvgl_touch` should still work for the `stm32f746g-disco` board. ``` BOARD=stm32f746g-disco make -C tests/pkg/lvgl_touch ``` ### Issues/PRs references ~Depends on PR #19860~ Depends on PR #19866 Co-authored-by: Gunar Schorcht <[email protected]>

drivers/fx5x06: fix vendor ID for FT6xx6

0df9480

The vendor ID of FT6xx6 touch panel driver ICs is `0x11` instead of `0xcd`.

github-actions bot added the Area: drivers Area: Device drivers label Aug 6, 2023

gschorcht requested a review from aabadie August 6, 2023 15:50

gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 6, 2023

benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 7, 2023

benpicco approved these changes Aug 7, 2023

View reviewed changes

gschorcht added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Aug 7, 2023

gschorcht added State: invalid State: The issue / PR is not valid and removed State: invalid State: The issue / PR is not valid State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Aug 7, 2023

gschorcht changed the title ~~drivers/fx5x06: fix vendor ID for FT6xx6~~ drivers/fx5x06: fix vendor ID for FT6xx6 and FTxxxx register addresses Aug 9, 2023

gschorcht force-pushed the drivers/ft5x06_fix_vendor_id branch from 2d26165 to 766f0f4 Compare August 9, 2023 08:20

This was referenced Aug 9, 2023

drivers/ft5x06: use a pointer to config parameters instead of copying them #19866

Merged

drivers/ft5x06: introduce conversion for X and Y coordinates #19867

Merged

gschorcht mentioned this pull request Aug 14, 2023

drivers/touch_dev_gestures: add gesture recognition for touch devices #19884

Merged

5 tasks

drivers/ft5x06: fix register addresses

a9f3ce1

gschorcht force-pushed the drivers/ft5x06_fix_vendor_id branch from 766f0f4 to a9f3ce1 Compare August 14, 2023 22:06

gschorcht changed the title ~~drivers/fx5x06: fix vendor ID for FT6xx6 and FTxxxx register addresses~~ drivers/ft5x06: fix vendor ID for FT6xx6 and FTxxxx register addresses Aug 15, 2023

benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 23, 2023

gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 23, 2023

bors bot merged commit 2a4496b into RIOT-OS:master Aug 23, 2023

gschorcht deleted the drivers/ft5x06_fix_vendor_id branch August 30, 2023 16:47

MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers/ft5x06: fix vendor ID for FT6xx6 and FTxxxx register addresses#19860

drivers/ft5x06: fix vendor ID for FT6xx6 and FTxxxx register addresses#19860
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
gschorcht:drivers/ft5x06_fix_vendor_id

gschorcht commented Aug 6, 2023 •

edited

Loading

Uh oh!

riot-ci commented Aug 6, 2023 •

edited

Loading

Uh oh!

benpicco left a comment

Uh oh!

gschorcht commented Aug 7, 2023

Uh oh!

gschorcht commented Aug 9, 2023 •

edited

Loading

Uh oh!

gschorcht commented Aug 14, 2023

Uh oh!

benpicco commented Aug 14, 2023

Uh oh!

gschorcht commented Aug 14, 2023

Uh oh!

benpicco commented Aug 23, 2023

Uh oh!

bors bot commented Aug 23, 2023

Uh oh!

benpicco commented Aug 23, 2023

Uh oh!

bors bot commented Aug 23, 2023

Uh oh!

gschorcht commented Aug 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gschorcht commented Aug 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

riot-ci commented Aug 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

gschorcht commented Aug 7, 2023

Uh oh!

gschorcht commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gschorcht commented Aug 14, 2023

Uh oh!

benpicco commented Aug 14, 2023

Uh oh!

gschorcht commented Aug 14, 2023

Uh oh!

benpicco commented Aug 23, 2023

Uh oh!

bors bot commented Aug 23, 2023

Uh oh!

benpicco commented Aug 23, 2023

Uh oh!

bors bot commented Aug 23, 2023

Uh oh!

gschorcht commented Aug 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gschorcht commented Aug 6, 2023 •

edited

Loading

riot-ci commented Aug 6, 2023 •

edited

Loading

gschorcht commented Aug 9, 2023 •

edited

Loading