gnrc_static: fix static PID assignment#19855
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Aug 7, 2023
Merged
Conversation
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
benpicco
added
Type: bug
maribu
approved these changes
Aug 2, 2023
Member
|
Maybe we should also align the semantics of |
Contributor
Author
|
Certainly! bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2023
19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
bors bot
added a commit
that referenced
this pull request
Aug 2, 2023
19854: cpu/esp_common: esp-wifi: drop assert(val) r=benpicco a=benpicco 19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2023
19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
|
Build failed: |
Contributor
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
19824: boards/sipeed_longan_nano: separate board definition for Sipeed Longan Nano TFT r=benpicco a=gschorcht ### Contribution description This PR provides a minimal separate board definition for the Sipeed Longan Nano version with TFT display which is just an extension of `boards/sipeed-longan-nano` with enabled TFT display module. From the lessons we had to learn with the Kconfig modelling of optional hardware, the TFT version of the Sipeed Longan Nano board has been split off into its own board definition based on the existing Siepeed Longan Nano board. Commits ba29a5e, 237819e, 6d8b56d and c5faf34 are small cleanups of peripheral configurations and could be split from this PR as follow-up PR (changes +70 -36). ### Testing procedure Green CI ``` BOARD=sipeed-longan-nano-tft make -j8 -C tests/drivers/st77xx flash ``` should work ### Issues/PRs references Follow up to PR #19813 and PR #19814 Prerequisite for PR #19825 and PR #19827 19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
Author
|
bors cancel |
Contributor
|
Canceled. |
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Both
CONFIG_GNRC_IPV6_STATIC_ADDR_UPSTREAMandCONFIG_GNRC_IPV6_STATIC_ADDR_DOWNSTREAMget set to 0 if they are not defined, so we don't need theIS_ACTIVE()- in fact, usingIS_ACTIVE()leads to wrong results here.Testing procedure
Build an application with
Turns out the
IS_ACTIVE(DCONFIG_GNRC_IPV6_STATIC_ADDR_UPSTREAM)would evaluate tofalse.Issues/PRs references
https://forum.riot-os.org/t/border-router-ota-using-wifi/3895/24