cpu/esp_common: esp-wifi: drop assert(val)#19854
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Aug 3, 2023
Merged
Conversation
benpicco
added
Type: bug
github-actions
bot
added
Platform: ESP
gschorcht
approved these changes
Aug 2, 2023
Contributor
|
borse merge |
Contributor
|
Why is merging blocked? |
Contributor
Author
😉 bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2023
19854: cpu/esp_common: esp-wifi: drop assert(val) r=benpicco a=benpicco 19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
🙈 |
Contributor
Auto correction on mobile |
Contributor
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2023
19854: cpu/esp_common: esp-wifi: drop assert(val) r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
|
Build failed: |
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
assert()in_esp_wifi_getis excessive and wrong forNETOPT_IS_WIREDwhereval == NULLis valid.Testing procedure
Running applications that query the
NETOPT_IS_WIREDoption (e.g.gnrc_ipv6_static_addr) should now work without triggering the assertion.Issues/PRs references
https://forum.riot-os.org/t/border-router-ota-using-wifi/3895/24