AVR-8: Implement Power Management#19784
Merged
maribu merged 8 commits intoRIOT-OS:masterfrom Dec 1, 2023
Merged
Conversation
github-actions
bot
added
Platform: AVR
nandojve
force-pushed
the
avr8/implement_pm
branch
from
8d09e1b to
601ba05
Compare
nandojve
requested review from
MrKevinWeiss,
jia200x,
kYc0o,
kaspar030,
leandrolanzieri and
maribu
as code owners
benpicco
added
the
CI: ready for build
nandojve
force-pushed
the
avr8/implement_pm
branch
3 times, most recently
from
1f05ebc to
3d1e300
Compare
Contributor
Author
|
I have impression that Murdock is randomly failing. |
Member
|
The order in which app+board pairs are build is pretty random and the CI run stops once the first failure is hit. This could indeed result in pretty random failures, if more than on app fails. The lasted failure (different modules used when building with diff --git a/cpu/avr8_common/Kconfig b/cpu/avr8_common/Kconfig
index 03a0f40b5a..d82c187042 100644
--- a/cpu/avr8_common/Kconfig
+++ b/cpu/avr8_common/Kconfig
@@ -12,6 +12,8 @@ config CPU_ARCH_AVR8
select HAS_ARCH_AVR8
select HAS_PERIPH_PM
+ select MODULE_AVR8_COMMON_PERIPH if TEST_KCONFIG
+ select MODULE_PM_LAYERED if TEST_KCONFIG
select MODULE_MALLOC_THREAD_SAFE if TEST_KCONFIG
select MODULE_TINY_STRERROR_AS_STRERROR if TEST_KCONFIG
# static C++ constructors need guards for thread safe initialization
@@ -41,6 +43,13 @@ config MODULE_AVR8_COMMON
help
AVR-8 common code.
+config MODULE_AVR8_COMMON_PERIPH
+ bool
+ depends on TEST_KCONFIG
+ default y
+ help
+ Common peripheral drivers used across different AVR-8 MCU families.
+
# the atmel port uses stdio_uart by default
choice STDIO_IMPLEMENTATION
default MODULE_STDIO_UARTThis one: is indeed a race condition in the build system that is triggered when compiling that app for |
nandojve
force-pushed
the
avr8/implement_pm
branch
from
3d1e300 to
3432f5b
Compare
Contributor
Author
|
This seems ready to go! |
nandojve
force-pushed
the
avr8/implement_pm
branch
from
3432f5b to
d61157f
Compare
Contributor
Author
|
rebased since #19777 got merged. |
Contributor
Author
|
I was wondering if there is anything pending on this : ) |
Contributor
Author
|
ping |
Contributor
|
I can pick this up after I finish with the release, feel free to ping me in a few days. |
Contributor
Author
|
Ping @MrKevinWeiss : ) |
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
After a quick look things seem OK, maybe some logic issues for your consideration. I will try to test tomorrow when I am in the office. (I need to also familiarize myself with the whole PM stuff).
maribu
force-pushed
the
avr8/implement_pm
branch
from
f7c6b02 to
86ef5fd
Compare
Member
|
I'll also do the rebase to resolve the merge conflict |
This refactor the current xmega PM peripheral to avr8 common and extend PM to cpus families. Signed-off-by: Gerson Fernando Budke <[email protected]>
Fix the required PM state on i2c and spi peripherals. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add PM blocks to adc/i2c/spi peripherals. Signed-off-by: Gerson Fernando Budke <[email protected]>
This is necessary to allow run the thread_duel example. Signed-off-by: Gerson Fernando Budke <[email protected]>
The board have one user button and a user led but are not enabled. This add necessary support to use the button and the led. It include the configs to use with SAUL and button interrupt. Signed-off-by: Gerson Fernando Budke <[email protected]>
Co-authored-by: Marian Buschsieweke <[email protected]> Signed-off-by: Gerson Fernando Budke <[email protected]>
Co-authored-by: MrKevinWeiss <[email protected]> Signed-off-by: Gerson Fernando Budke <[email protected]>
maribu
force-pushed
the
avr8/implement_pm
branch
from
86ef5fd to
a50ba48
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Looks like #20130 contains a bug :-/ |
Ran dist/tools/insufficient_memory for all AVR8 boards.
maribu
force-pushed
the
avr8/implement_pm
branch
from
a50ba48 to
82d98ed
Compare
maribu
added
CI: ready for build
Contributor
Author
|
Thank you for all help @maribu and @MrKevinWeiss |
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The Xmega have a Power Management implementation. This moves that code to AVR-8 common and enable Power Management for all variants.
Testing procedure
This was tested using examples/thread_duel and tests/periph/pm examples on atxmega-a1u-xpro and atmega328p-xplained-mini boards. It may requires more tests and any help is welcome.
Issues/PRs references
This is a preparation for future scheduling and IRQ optimizations.