Merged
Conversation
hugueslarrive
requested review from
MrKevinWeiss,
jia200x,
kYc0o,
leandrolanzieri and
maribu
as code owners
github-actions
bot
added
Area: doc
This was referenced Jun 22, 2023
benpicco
added
the
State: waiting for other PR
benpicco
added
CI: ready for build
benpicco
reviewed
Jul 5, 2023
Comment on lines
+19
to
+24
| * @author Hauke Petersen <[email protected]> | ||
| * @author Hinnerk van Bruinehsen <[email protected]> | ||
| * @author Josua Arndt <[email protected]> | ||
| * @author Steffen Robertz <[email protected]> | ||
| * @author Matthew Blue <[email protected]> | ||
| * @author Hugues Larrive <[email protected]> |
Contributor
There was a problem hiding this comment.
It's totally sufficient to just put yourself here, this is just config and boiler plate.
benpicco
approved these changes
Jul 5, 2023
Contributor
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
added a commit
that referenced
this pull request
Jul 11, 2023
19754: boards/atmega8: new board r=benpicco a=hugueslarrive ### Contribution description Splitted from: - #19740 ### Testing procedure Tested on atmega8 with: - #19755 ### Issues/PRs references Dependencies: - #19753 - #19752 - #19751 19798: cpu/nrf53: add I2C and SPI support r=benpicco a=dylad ### Contribution description This PR provides support for nRF53 SPI and I2C. It also moves common structs from each nRF CPU folder to `cpu/nrf5x_common` to avoid duplication. Moreover, since nRF9160 and nRF5340 have shared IRQ for UART/SPI/I2C. Both this families now use a common file to register and manage these interrupts. Note that nRF9160 have different name for its interrupts than nRF5340 but they have the same purpose. ### Testing procedure Since some structs were moved around, I think this PR should be carefully tested against nRF52, nRF53 and nRF9160 to avoid any issues. On nRF5340DK-APP, SPI can be tested with its onboard SPI flash. ### Issues/PRs references Co-authored-by: Hugues Larrive <[email protected]> Co-authored-by: Dylan Laduranty <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Splitted from:
Testing procedure
Tested on atmega8 with:
Issues/PRs references
Dependencies: