mcufont: Initial addition of MCUFont package by bergzand · Pull Request #19726 · RIOT-OS/RIOT

bergzand · 2023-06-11T20:25:30Z

Contribution description

This adds the MCUFont library as a package to RIOT. Only the decoder part has been packaged. I did not touch the font generation, so the test includes a manually compressed font created via the tooling included in the package.

The included patch files have been submitted as PR upstream in mcufont/mcufont#30

Testing procedure

Run the test on Native or on any board, The output should be along the lines of:

2023-06-11 21:56:40,685 # Help: Press s to start test, r to print it is ready
s
2023-06-11 21:56:42,651 # START
2023-06-11 21:56:42,652 # main(): This is RIOT! (Version: 2023.07-devel-512-g49ee9-pr/mcufont)
2023-06-11 21:56:42,652 # Generated RIOT application: 'mcufont'
2023-06-11 21:56:42,653 #                                                                                                                                 |
2023-06-11 21:56:42,654 #                                                                                                                                 |
2023-06-11 21:56:42,694 #                   █  █                                                                                                          |
2023-06-11 21:56:42,695 #  █     █          █  █                  █████   █    ███   ███████  █                                                           |
2023-06-11 21:56:42,697 #  █     █          █  █                  █    █  █   █   █     █     █                                                           |
2023-06-11 21:56:42,737 #  █     █   ████   █  █   ████           █    █  █  █     █    █     █                                                           |
2023-06-11 21:56:42,739 #  █     █  ██  ██  █  █  ██  ██          █    █  █  █     █    █     █                                                           |
2023-06-11 21:56:42,740 #  ███████  █    █  █  █  █    █          █████   █  █     █    █     █                                                           |
2023-06-11 21:56:42,781 #  █     █  ██████  █  █  █    █          █   █   █  █     █    █     █                                                           |
2023-06-11 21:56:42,782 #  █     █  █       █  █  █    █          █    █  █  █     █    █                                                                 |
2023-06-11 21:56:42,783 #  █     █  ██   █  █  █  ██  ██  █       █    █  █   █   █     █     █                                                           |
2023-06-11 21:56:42,807 #  █     █   ████   █  █   ████   █       █     █ █    ███      █     █                                                           |
2023-06-11 21:56:42,807 # { "threads": [{ "name": "idle", "stack_size": 256, "stack_used": 220 }]}
2023-06-11 21:56:42,808 # { "threads": [{ "name": "main", "stack_size": 1280, "stack_used": 436 }]}

Issues/PRs references

None

riot-ci · 2023-06-11T20:32:44Z

Murdock results

✔️ PASSED

e2e9c0c tests/pkg/mcufont: Initial include of MCUFont test

Success	Failures	Total	Runtime
7923	0	7923	14m:49s

Artifacts

Documentation preview

pkg/mcufont/Makefile.dep

aabadie · 2023-06-12T07:48:05Z

tests/pkg/mcufont/main.c

+            input, strlen(input),
+            &char_callback, NULL);
+
+    print_pixbuf();


It would be nice if the message was also displayed on a screen for boards that provide one. The qrcode package test application does that.

Added something that works (not something great though):

pkg/mcufont/patches/0002-decoder-Make-unused-parameters-explicit.patch

aabadie

Tested on native and stm32f429i-disc1 and works like a charm. I have a couple of comments.

aabadie · 2023-06-23T10:17:39Z

tests/pkg/mcufont/main.c

+        puts("mcufont package test application");
+        mf_render_aligned(
+                &MCUFONT_DISP_TEST_FONT.font,
+                0, 0,


Is it possible to compute coordinates to diplay the test in the center of the screen?

Yes, added a bit that centers the output with respect to the screen size and the string length.

tests/pkg/mcufont/tests/01-run.py

aabadie

Some remaining nits. Will test in hardware now

tests/pkg/mcufont/tests/01-run.py

aabadie · 2023-08-11T15:51:50Z

Will test in hardware now

Still works like a charm (on adafruit- clue). Please squash!

bergzand · 2023-08-11T17:48:48Z

Squashed and all green

aabadie

ACK

bors merge

19726: mcufont: Initial addition of MCUFont package r=aabadie a=bergzand ### Contribution description This adds the MCUFont library as a package to RIOT. Only the decoder part has been packaged. I did not touch the font generation, so the test includes a manually compressed font created via the tooling included in the package. The included patch files have been submitted as PR upstream in mcufont/mcufont#30 ### Testing procedure Run the test on Native or on any board, The output should be along the lines of: ``` 2023-06-11 21:56:40,685 # Help: Press s to start test, r to print it is ready s 2023-06-11 21:56:42,651 # START 2023-06-11 21:56:42,652 # main(): This is RIOT! (Version: 2023.07-devel-512-g49ee9-pr/mcufont) 2023-06-11 21:56:42,652 # Generated RIOT application: 'mcufont' 2023-06-11 21:56:42,653 # | 2023-06-11 21:56:42,654 # | 2023-06-11 21:56:42,694 # █ █ | 2023-06-11 21:56:42,695 # █ █ █ █ █████ █ ███ ███████ █ | 2023-06-11 21:56:42,697 # █ █ █ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,737 # █ █ ████ █ █ ████ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,739 # █ █ ██ ██ █ █ ██ ██ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,740 # ███████ █ █ █ █ █ █ █████ █ █ █ █ █ | 2023-06-11 21:56:42,781 # █ █ ██████ █ █ █ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,782 # █ █ █ █ █ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,783 # █ █ ██ █ █ █ ██ ██ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,807 # █ █ ████ █ █ ████ █ █ █ █ ███ █ █ | 2023-06-11 21:56:42,807 # { "threads": [{ "name": "idle", "stack_size": 256, "stack_used": 220 }]} 2023-06-11 21:56:42,808 # { "threads": [{ "name": "main", "stack_size": 1280, "stack_used": 436 }]} ``` ### Issues/PRs references None Co-authored-by: Koen Zandberg <[email protected]>

bors · 2023-08-11T20:05:46Z

Build failed:

Murdock

tests/pkg/mcufont/Makefile.ci

aabadie · 2023-08-15T15:13:42Z

bors merge

19726: mcufont: Initial addition of MCUFont package r=aabadie a=bergzand ### Contribution description This adds the MCUFont library as a package to RIOT. Only the decoder part has been packaged. I did not touch the font generation, so the test includes a manually compressed font created via the tooling included in the package. The included patch files have been submitted as PR upstream in mcufont/mcufont#30 ### Testing procedure Run the test on Native or on any board, The output should be along the lines of: ``` 2023-06-11 21:56:40,685 # Help: Press s to start test, r to print it is ready s 2023-06-11 21:56:42,651 # START 2023-06-11 21:56:42,652 # main(): This is RIOT! (Version: 2023.07-devel-512-g49ee9-pr/mcufont) 2023-06-11 21:56:42,652 # Generated RIOT application: 'mcufont' 2023-06-11 21:56:42,653 # | 2023-06-11 21:56:42,654 # | 2023-06-11 21:56:42,694 # █ █ | 2023-06-11 21:56:42,695 # █ █ █ █ █████ █ ███ ███████ █ | 2023-06-11 21:56:42,697 # █ █ █ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,737 # █ █ ████ █ █ ████ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,739 # █ █ ██ ██ █ █ ██ ██ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,740 # ███████ █ █ █ █ █ █ █████ █ █ █ █ █ | 2023-06-11 21:56:42,781 # █ █ ██████ █ █ █ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,782 # █ █ █ █ █ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,783 # █ █ ██ █ █ █ ██ ██ █ █ █ █ █ █ █ █ | 2023-06-11 21:56:42,807 # █ █ ████ █ █ ████ █ █ █ █ ███ █ █ | 2023-06-11 21:56:42,807 # { "threads": [{ "name": "idle", "stack_size": 256, "stack_used": 220 }]} 2023-06-11 21:56:42,808 # { "threads": [{ "name": "main", "stack_size": 1280, "stack_used": 436 }]} ``` ### Issues/PRs references None Co-authored-by: Koen Zandberg <[email protected]>

bors · 2023-08-15T18:31:32Z

Build failed:

Murdock

aabadie · 2023-08-15T21:07:59Z

bors merge

bors · 2023-08-16T01:06:23Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

bergzand · 2023-08-16T08:13:47Z

Thanks!

bergzand requested review from MichelRottleuthner, MrKevinWeiss, aabadie, fjmolinas, jia200x, leandrolanzieri and smlng as code owners June 11, 2023 20:25

bergzand added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jun 11, 2023

github-actions bot added Area: build system Area: Build system Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Jun 11, 2023

bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 11, 2023

aabadie reviewed Jun 12, 2023

View reviewed changes

pkg/mcufont/Makefile.dep Outdated Show resolved Hide resolved

aabadie reviewed Jun 12, 2023

View reviewed changes

bergzand removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 12, 2023

benpicco reviewed Jun 12, 2023

View reviewed changes

pkg/mcufont/patches/0002-decoder-Make-unused-parameters-explicit.patch Outdated Show resolved Hide resolved

bergzand added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: no fast fail don't abort PR build after first error and removed CI: no fast fail don't abort PR build after first error labels Jun 12, 2023

aabadie reviewed Jun 23, 2023

View reviewed changes

aabadie reviewed Aug 11, 2023

View reviewed changes

tests/pkg/mcufont/tests/01-run.py Show resolved Hide resolved

tests/pkg/mcufont/tests/01-run.py Outdated Show resolved Hide resolved

aabadie mentioned this pull request Aug 11, 2023

makefiles/usb_board_reset.mk: declare term-delay target with test target #19878

Merged

bergzand force-pushed the pr/mcufont branch 2 times, most recently from cb1e35e to 2df0a80 Compare August 11, 2023 17:04

aabadie approved these changes Aug 11, 2023

View reviewed changes

bergzand added 2 commits August 14, 2023 15:50

mcufont: Initial addition of mcufont package

a17afa7

tests/pkg/mcufont: Initial include of MCUFont test

e2e9c0c

bergzand force-pushed the pr/mcufont branch from 2df0a80 to e2e9c0c Compare August 14, 2023 14:00

aabadie reviewed Aug 14, 2023

View reviewed changes

tests/pkg/mcufont/Makefile.ci Show resolved Hide resolved

aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 15, 2023

bors bot merged commit 4b1b0a9 into RIOT-OS:master Aug 16, 2023

bergzand deleted the pr/mcufont branch August 16, 2023 08:13

MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023

Conversation

bergzand commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

riot-ci commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

Uh oh!

aabadie Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergzand Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

aabadie Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

bergzand Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aabadie commented Aug 11, 2023

Uh oh!

bergzand commented Aug 11, 2023

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

bors bot commented Aug 11, 2023

Uh oh!

Uh oh!

aabadie commented Aug 15, 2023

Uh oh!

bors bot commented Aug 15, 2023

Uh oh!

aabadie commented Aug 15, 2023

Uh oh!

bors bot commented Aug 16, 2023

Uh oh!

bergzand commented Aug 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bergzand commented Jun 11, 2023 •

edited

Loading

riot-ci commented Jun 11, 2023 •

edited

Loading

aabadie Jun 12, 2023 •

edited

Loading