sys: net: Initial import of a simple data-forwarding MAC protocol (nomac) by miri64 · Pull Request #1968 · RIOT-OS/RIOT

miri64 · 2014-11-07T17:16:16Z

This is basically an adapter translating netapi IPC calls into netdev function calls.

Depends on ~~#1448~~ (merged) and ~~#2027~~ (merged)

miri64 · 2014-11-08T00:03:29Z

@Kijewski unittests on qemu-i386 say

2014-11-08 01:01:30.658450: basic_mac_tests.test_basic_mac_send_data_send (/home/martine/Repositories/RIOT-OS/RIOT/tests/unittests/tests-basic_mac/tests-basic_mac.c 171) exp 8 was 8

Can't compute =D

Kijewski · 2014-11-08T00:39:03Z

This happens when one does not implement macros properly. Please see miri64#8.

miri64 · 2014-11-11T15:30:42Z

Rebased

miri64 · 2014-11-18T15:59:59Z

Added #2027 as dependency

miri64 · 2014-11-21T12:37:46Z

Rebased to #2027

haukepetersen · 2014-11-21T13:28:10Z

looking (very) fast over this, I think it looks quite well. One thing that came to my mind is maybe renaming the mac implementation slightly? I was thinking about something like mac_nomac or mac_none. This would give a nice structure for different MAC layers:

RIOTDIR/sys/net/link_layer/mac_nomac/xx.c
RIOTDIR/sys/net/link_layer/mac_tdma/xx.c
RIOTDIR/sys/net/link_layer/mac_fdma/xx.c
RIOTDIR/sys/net/link_layer/mac_ieee802154e/xx.c

What do you guys think?

miri64 · 2014-11-21T13:43:40Z

Apart from me needing to rename it everywhere I have basically no objections. I even can see the benefit of it :-)

OlegHahm · 2014-11-21T13:44:01Z

Or rename link_layer into llc and create a new folder mac?

miri64 · 2014-11-21T13:45:17Z

llc standing for what?

miri64 · 2014-11-21T13:46:11Z

And isn't that counter-intuitive to your rational behind the directory hierarchy in RIOT?

OlegHahm · 2014-11-21T13:49:47Z

The two sublayers of (data) link layer are logical link control and media access control and I would find it much easier to locate the protocol implementations that way.

miri64 · 2014-11-21T13:50:45Z

(rebased to master)

OlegHahm · 2015-01-11T22:47:17Z

tests/unittests/tests-nomac/tests-nomac.c

Where is msg.type set?

Somehow git grep gave some weird results yesterday.

Please clarify.

Never mind. I don't know what went wrong, but I overlooked the mentioned line.

OlegHahm · 2015-01-11T23:18:02Z

Apart from the comments, I'm fine and think this is ready for squashing, but I would feel more comfortable if @haukepetersen or someone else could review, too.

miri64 · 2015-01-12T12:01:09Z

Addressed comments.

miri64 · 2015-01-12T12:01:41Z

@OlegHahm Was your last comment a request to squash?

OlegHahm · 2015-01-12T14:17:30Z

If @haukepetersen agrees, yes.

OlegHahm · 2015-01-12T14:17:59Z

To be clear: this is an ACK but I request a second reviewer.

miri64 · 2015-01-12T14:24:03Z

Then @haukepetersen should do so :D

haukepetersen · 2015-01-13T17:38:45Z

sys/net/include/nomac.h

I would not make this parameter static, but allocate it on the nomac thread's stack and give it as parameter during initialization...

see https://github.com/RIOT-OS/RIOT/pull/1968/files#r22900329

haukepetersen · 2015-01-13T17:45:49Z

done :-) Just some small remarks/proposals. As I see it, some parts or subject to change with the upcoming pkt_t and others -> so I would ack and merge this PR when comments are addressed and squashed and adapt to upcoming changes as we go...

miri64 · 2015-01-13T22:34:12Z

I addressed your proposals. Since a thread-local registry would require another API change to netdev (e.g. a context parameter to netdev_rcv_data_cb_t), I would suggest we merge this PR first and focus later on the thread-local registry.

haukepetersen · 2015-01-13T22:35:41Z

Ok, sounds valid. ACK when squashed.

miri64 · 2015-01-13T22:44:46Z

Squashed

OlegHahm · 2015-01-14T00:09:06Z

Kicked Travis.

OlegHahm · 2015-01-14T00:21:18Z

tests/unittests/tests-nomac/tests-nomac.h

Doesn't exist!?

Was it moved in the last few weeks? (it compiles locally)

miri64 · 2015-01-14T06:04:33Z

Rebased to master and adapted unittest includes to #2102.

sys: net: Initial import of a simple data-forwarding MAC protocol (nomac)

miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: network Area: Networking labels Nov 7, 2014

miri64 added this to the Release NEXT MAJOR milestone Nov 7, 2014

miri64 assigned haukepetersen Nov 7, 2014

miri64 mentioned this pull request Nov 7, 2014

transceiver: netapi adapter #1969

Closed

miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 7, 2014

miri64 mentioned this pull request Nov 8, 2014

embunit: fix macros miri64/RIOT#8

Closed

miri64 force-pushed the basic_mac branch from fb0d912 to 1a8abe5 Compare November 11, 2014 15:30

miri64 mentioned this pull request Nov 12, 2014

WIP IPv6 refactoring #2003

Closed

miri64 added a commit to miri64/RIOT that referenced this pull request Nov 14, 2014

Merge branch 'basic_mac' (RIOT-OS#1968) into ipv6-refactor

4328d12

miri64 added a commit to miri64/RIOT that referenced this pull request Nov 14, 2014

Merge branch 'basic_mac' (RIOT-OS#1968) into ipv6-refactor

99726c9

miri64 force-pushed the basic_mac branch from 1a8abe5 to f4a7d40 Compare November 18, 2014 15:58

miri64 force-pushed the basic_mac branch 2 times, most recently from 99ec277 to 0f0d2ba Compare November 21, 2014 12:35

miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Nov 21, 2014

miri64 added a commit to miri64/RIOT that referenced this pull request Nov 21, 2014

Merge branch 'basic_mac' (RIOT-OS#1968) into ipv6-refactor

907b654

miri64 force-pushed the basic_mac branch from d91ed90 to 5bb3f9b Compare November 21, 2014 13:49

OlegHahm reviewed Jan 11, 2015
View reviewed changes

miri64 mentioned this pull request Jan 12, 2015

Network stack refactoring: TODO list #2278

Closed

36 tasks

miri64 mentioned this pull request Jan 12, 2015

netapi: adapt to pkt_t #2286

Closed

haukepetersen reviewed Jan 13, 2015
View reviewed changes

miri64 force-pushed the basic_mac branch from c821d80 to 448fcec Compare January 13, 2015 22:44

miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jan 13, 2015

OlegHahm reviewed Jan 14, 2015
View reviewed changes

Martin Lenders and others added 2 commits January 14, 2015 06:58

sys: net: Initial import of a basic MAC protocol layer

96502e2

unittests: provide unittests for basic_mac

0221c27

miri64 force-pushed the basic_mac branch from 448fcec to 0221c27 Compare January 14, 2015 06:00

OlegHahm added a commit that referenced this pull request Jan 14, 2015

Merge pull request #1968 from authmillenon/basic_mac

5926697

sys: net: Initial import of a simple data-forwarding MAC protocol (nomac)

OlegHahm merged commit 5926697 into RIOT-OS:master Jan 14, 2015

miri64 deleted the basic_mac branch January 14, 2015 07:33

OlegHahm modified the milestones: Release 2015.09, Release 2015.12 Dec 18, 2015

Conversation

miri64 commented Nov 7, 2014

Uh oh!

miri64 commented Nov 8, 2014

Uh oh!

Kijewski commented Nov 8, 2014

Uh oh!

miri64 commented Nov 11, 2014

Uh oh!

miri64 commented Nov 18, 2014

Uh oh!

miri64 commented Nov 21, 2014

Uh oh!

haukepetersen commented Nov 21, 2014

Uh oh!

miri64 commented Nov 21, 2014

Uh oh!

OlegHahm commented Nov 21, 2014

Uh oh!

miri64 commented Nov 21, 2014

Uh oh!

miri64 commented Nov 21, 2014

Uh oh!

OlegHahm commented Nov 21, 2014

Uh oh!

miri64 commented Nov 21, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Jan 11, 2015

Uh oh!

miri64 commented Jan 12, 2015

Uh oh!

miri64 commented Jan 12, 2015

Uh oh!

OlegHahm commented Jan 12, 2015

Uh oh!

OlegHahm commented Jan 12, 2015

Uh oh!

miri64 commented Jan 12, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Jan 13, 2015

Uh oh!

miri64 commented Jan 13, 2015

Uh oh!

haukepetersen commented Jan 13, 2015

Uh oh!

miri64 commented Jan 13, 2015

Uh oh!

OlegHahm commented Jan 14, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 commented Jan 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants