Skip to content

gnrc_sixlowpan_frag_sfr: fix ARQ scheduler race-condition#19679

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_frag_sfr/bug/arq-scheduler-race
May 30, 2023
Merged

gnrc_sixlowpan_frag_sfr: fix ARQ scheduler race-condition#19679
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_frag_sfr/bug/arq-scheduler-race

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented May 30, 2023

Contribution description

See GHSA-8m3w-mphf-wxm8

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 30, 2023
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr/bug/arq-scheduler-race branch from 5b913e2 to 377bc51 Compare May 30, 2023 12:43
@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label May 30, 2023
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr/bug/arq-scheduler-race branch from 377bc51 to 7c28616 Compare May 30, 2023 12:50
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 30, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented May 30, 2023

Murdock results

✔️ PASSED

31c6191 gnrc_sixlowpan_frag_sfr: fix ARQ scheduler race-condition

Success Failures Total Runtime
6933 0 6933 16m:54s

Artifacts

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 30, 2023

Murdock results

FAILED

7c28616 gnrc_sixlowpan_frag_sfr: fix ARQ scheduler race-condition

Success Failures Total Runtime
4235 0 6933 06m:11s

Artifacts

Someone forgot to mention the failures? (/cc @aabadie)

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr/bug/arq-scheduler-race branch from a10b277 to 31c6191 Compare May 30, 2023 14:42
@maribu
Copy link
Copy Markdown
Member

maribu commented May 30, 2023

bors merge

bors bot added a commit that referenced this pull request May 30, 2023
19610: drivers/periph/rtc: improve doc on rtc_set_alarm r=maribu a=maribu

### Contribution description

- point out behavior on denormalized time stamps
- use errno codes to indicate errors (and adapt the few instances of actual error handling to use them)


19670: cpu/stm32: stm32f4 BRR from BSRR r=maribu a=kfessel

### Contribution description

sometimes one wants to save one instruction :) 
just write the bits we need to write.

### Testing procedure

tests/periph/gpio_ll tests this 

### Issues/PRs references

`@maribu` might know some reference

maybe #19407

19678: gnrc_sixlowpan_iphc: fix NULL pointer dereference r=maribu a=miri64



19679: gnrc_sixlowpan_frag_sfr: fix ARQ scheduler race-condition r=maribu a=miri64



19680: gnrc_sixlowpan_frag_rb: fix OOB write in _rbuf_add r=maribu a=miri64



19681: sys/xtimer: improve documentation r=maribu a=maribu

### Contribution description

- Add a warning that xtimer is deprecated, so that new code hopefully starts using ztimer
- Add a hint that `ztimer_xtimer_compat` can be used even after `xtimer` is gone


Co-authored-by: Marian Buschsieweke <[email protected]>
Co-authored-by: Karl Fessel <[email protected]>
Co-authored-by: Martine Lenders <[email protected]>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented May 30, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@bors
Copy link
Copy Markdown
Contributor

bors bot commented May 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 00b5bc1 into RIOT-OS:master May 30, 2023
@miri64 miri64 deleted the gnrc_sixlowpan_frag_sfr/bug/arq-scheduler-race branch May 30, 2023 20:29
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants