Skip to content

gnrc/ipv6_auto_subnets: allow to configure minimal prefix length#19656

Merged
bors[bot] merged 3 commits intoRIOT-OS:masterfrom
benpicco:gnrc_ipv6_auto_subnets-pfx_len
May 23, 2023
Merged

gnrc/ipv6_auto_subnets: allow to configure minimal prefix length#19656
bors[bot] merged 3 commits intoRIOT-OS:masterfrom
benpicco:gnrc_ipv6_auto_subnets-pfx_len

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented May 23, 2023 •
edited
Loading

Contribution description

Linux only accepts Router Advertisements for SLAAC if the prefix length is /64.
Add a config option to gnrc_ipv6_auto_subnets to create smaller subnets if necessary.

Testing procedure

A downstream Linux host gets a prefix from the upstream RIOT router with gnrc_ipv6_auto_subnets:

104: usb0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UNKNOWN group default qlen 1000
    link/ether 66:81:20:f9:aa:94 brd ff:ff:ff:ff:ff:ff
    inet 169.254.226.86/16 brd 169.254.255.255 scope global noprefixroute usb0
       valid_lft forever preferred_lft forever
    inet6 fd00:0:c000:0:e46:895a:43bc:f080/64 scope global dynamic mngtmpaddr noprefixroute 
       valid_lft 72155sec preferred_lft 155sec
    inet6 fe80::650a:e7fd:8b57:c7e8/64 scope link 
       valid_lft forever preferred_lft forever

fd00:0:c000::/64 dev usb0 proto ra metric 304 pref medium

Issues/PRs references

@benpicco benpicco requested a review from fabian18 May 23, 2023 15:14
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 23, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 23, 2023
@benpicco benpicco force-pushed the gnrc_ipv6_auto_subnets-pfx_len branch from 0e96896 to ef3b7dc Compare May 23, 2023 15:40
@benpicco benpicco requested a review from kaspar030 as a code owner May 23, 2023 15:40
@github-actions github-actions bot added the Area: core Area: RIOT kernel. Handle PRs marked with this with care! label May 23, 2023
fabian18
fabian18 approved these changes May 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably will have to use may_be_zero more often.

@benpicco benpicco force-pushed the gnrc_ipv6_auto_subnets-pfx_len branch from ef3b7dc to 2a76911 Compare May 23, 2023 15:46
@riot-ci
Copy link
Copy Markdown

riot-ci commented May 23, 2023

Murdock results

✔️ PASSED

2a76911 gnrc/ipv6_auto_subnets: allow to configure minimal prefix length

Success Failures Total Runtime
6946 0 6946 11m:54s

Artifacts

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented May 23, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented May 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a272abb into RIOT-OS:master May 23, 2023
@benpicco benpicco deleted the gnrc_ipv6_auto_subnets-pfx_len branch May 23, 2023 23:28
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabian18 fabian18 fabian18 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@cgundogan cgundogan Awaiting requested review from cgundogan

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees

No one assigned

Labels

Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2023.07

Development

Successfully merging this pull request may close these issues.

3 participants

@benpicco @riot-ci @fabian18