Skip to content

gnrc_sixlowpan_iphc: prefix bits outside context must be zero#19649

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
benpicco:gnrc_sixlowpan_iphc-64
May 23, 2023
Merged

gnrc_sixlowpan_iphc: prefix bits outside context must be zero#19649
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
benpicco:gnrc_sixlowpan_iphc-64

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented May 22, 2023 •
edited
Loading

Contribution description

Testing procedure

We have a /33 compression context

2023-05-23 11:41:47,813 - INFO # cid|prefix                                     |C|ltime
2023-05-23 11:41:47,819 - INFO # -----------------------------------------------------------
2023-05-23 11:41:47,823 - INFO #   0|                          fd00:0:8000::/33 |1| 1439min

And a route to a /64 subnet inside the previous network.

2023-05-23 11:41:55,146 - INFO # fd00::/32 dev #6
2023-05-23 11:41:55,148 - INFO # fd00:0:8000::/33 dev #5
2023-05-23 11:41:55,153 - INFO # fd00:0:c000::/64 via fe80::e858:4ed2:564e:345b dev #5
2023-05-23 11:41:55,157 - INFO # default via fe80::6a9a:4308:e40a:aa8a dev #6

We can successfully ping a host inside the /64 network.

2023-05-23 11:42:38,163 - INFO # > ping fd00:0:c000:0:6481:20ff:fef9:b694
2023-05-23 11:42:38,164 - INFO # 
2023-05-23 11:42:38,182 - INFO # 12 bytes from fd00:0:c000:0:6481:20ff:fef9:b694: icmp_seq=0 ttl=64 rssi=-26 dBm time=9.177 ms
2023-05-23 11:42:39,184 - INFO # 12 bytes from fd00:0:c000:0:6481:20ff:fef9:b694: icmp_seq=1 ttl=64 rssi=-25 dBm time=10.359 ms
2023-05-23 11:42:40,183 - INFO # 12 bytes from fd00:0:c000:0:6481:20ff:fef9:b694: icmp_seq=2 ttl=64 rssi=-25 dBm time=8.922 ms
2023-05-23 11:42:40,183 - INFO # 
2023-05-23 11:42:40,188 - INFO # --- fd00:0:c000:0:6481:20ff:fef9:b694 PING statistics ---
2023-05-23 11:42:40,193 - INFO # 3 packets transmitted, 3 packets received, 0% packet loss
2023-05-23 11:42:40,198 - INFO # round-trip min/avg/max = 8.922/9.486/10.359 ms

On master the compression context would be used instead, resulting in the packet being sent to the non-existing fd00:0:8000::6481:20ff:fef9:b694.

Issues/PRs references

alternative to #19648

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 22, 2023
@benpicco benpicco mentioned this pull request May 22, 2023
Closed
miri64
miri64 previously requested changes May 23, 2023
View reviewed changes
@benpicco benpicco force-pushed the gnrc_sixlowpan_iphc-64 branch from ec235c8 to a656114 Compare May 23, 2023 09:37
@benpicco benpicco requested a review from fabian18 May 23, 2023 09:45
@benpicco benpicco force-pushed the gnrc_sixlowpan_iphc-64 branch from a656114 to 7e9308d Compare May 23, 2023 12:16
fabian18
fabian18 approved these changes May 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good I would say. It fixes the issues described in the testing procedure. And miris comments were addressed I think

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 23, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented May 23, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 23, 2023
@riot-ci
Copy link
Copy Markdown

riot-ci commented May 23, 2023

Murdock results

✔️ PASSED

7e9308d gnrc_sixlowpan_iphc: prefix bits outside context must be zero

Success Failures Total Runtime
6946 0 6946 10m:51s

Artifacts

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented May 23, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented May 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a272abb into RIOT-OS:master May 23, 2023
@benpicco benpicco deleted the gnrc_sixlowpan_iphc-64 branch May 23, 2023 23:28
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 left review comments

@fabian18 fabian18 fabian18 approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees

No one assigned

Labels

Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2023.07

Development

Successfully merging this pull request may close these issues.

4 participants

@benpicco @miri64 @riot-ci @fabian18