gnrc_ipv6_nib: include RIO with all subnets in downstream RA#19644
Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom May 23, 2023
Merged
gnrc_ipv6_nib: include RIO with all subnets in downstream RA#19644bors[bot] merged 2 commits intoRIOT-OS:masterfrom
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
Conversation
Contributor
|
Why should it be optional in final RAs but is always included in normal RAs? |
benpicco
force-pushed
the
gnrc_nib-router_rio
branch
from
62e1fe1 to
5e182b5
Compare
benpicco
force-pushed
the
gnrc_nib-router_rio
branch
from
5e182b5 to
4a5d68a
Compare
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
Contributor
Author
|
It's now also optional in normal RAs (and even more so as it's only needed when we are a) not the default router but have b) a route to a specific subnet we want to propagate). |
fabian18
reviewed
May 23, 2023
benpicco
force-pushed
the
gnrc_nib-router_rio
branch
from
4a5d68a to
fa5fd21
Compare
benpicco
added
the
CI: ready for build
fabian18
reviewed
May 23, 2023
Contributor
|
I'd say resolve the conflict and let's go. |
benpicco
force-pushed
the
gnrc_nib-router_rio
branch
from
fa5fd21 to
41f9c25
Compare
fabian18
approved these changes
May 23, 2023
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When RIOT is an upstream router to a subnet, but not the default route, we need to convey the information that this subnet is available through it to the downstream hosts.
Testing procedure
A riot board is connected to a Raspberry Pi over USB. The Raspberry Pi also has a WiFi uplink that constitutes it's default route.
The RIOT node is part of the
fd00::/32network, but by use ofgnrc_ipv6_auto_subnetsit's actually in thefd00:0:c000::/64subnet.To reach the
fd00::1host at the root of the upstream subnet, we have to inform the Raspberry Pi that the entire fd00::/32network is reachable through the RIOT node, not justfd00:0:c000::/64` - we can use the Route Information Option for that.We don't want to include redundant RIOs in the RA, e.g. the networks
fd00:0:8000::/33andfd00:0:c000::/64are both included infd00::/32(which is also reachable through our node) so we only have to include that one.and on the Linux side
Issues/PRs references