tests/build_system/external_board_dirs: fix broken symlinks#19584
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom May 12, 2023
Merged
Conversation
aabadie
added
Type: bug
aabadie
requested review from
MichelRottleuthner,
fjmolinas,
leandrolanzieri and
smlng
as code owners
aabadie
added
the
CI: ready for build
maribu
approved these changes
May 12, 2023
Member
|
bors merge |
bors bot
added a commit
that referenced
this pull request
May 12, 2023
19573: cpu/stm32/periph_dac: small improvements r=maribu a=gschorcht ### Contribution description This PR provides the following improvements for `periph_dac` on STM32 - Support for `RCC_APB1ENR1_DAC1EN` symbol added. - For boards that have not connected the V_REF+ pin to an external reference voltage, the VREFBUF peripheral can be used as V_REF+ (if supported) by setting `VREFBUF_ENABLE=1`. - If the DAC peripheral has a mode register (`DAC_MCR`), it is set to normal mode with buffer enabled and connected to external pin and on-chip peripherals. This allows to measure the current value of a DAC channel with an ADC channel or to use the DAC channel also for other on-chip peripherals. ### Testing procedure - Green CI - `tests/periph_dac` should still work for any board supporting the `periph_dac` feature. ### Issues/PRs references 19584: tests/build_system/external_board_dirs: fix broken symlinks r=maribu a=aabadie Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Alexandre Abadie <[email protected]>
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
For native1 and native1 external boards, symlinks to boards/native are used. After #19567 these symlinks were broken and for some reason they went through the CI. This PR is fixing them.
Testing procedure
Green CI
Issues/PRs references
#19567